Skip to content

Commit

Permalink
build: lock file maintenance to avoid node module differences for bab…
Browse files Browse the repository at this point in the history
…el types

We recently updated Babel and the Bazel types but this actually
resulted in duplicates, causing differences between what people
seen in their IDE vs. what Bazel builds.

This commit removes the lock file and generates it fully fresh,
deduping dependencies and also fixing the differences between
local IDE and Bazel.

As part of this we also need to update/fixup one assertion on the
Babel node path types, because the node start/end can now also
be `undefined`.
  • Loading branch information
devversion committed May 20, 2022
1 parent 9c83466 commit 52626d8
Show file tree
Hide file tree
Showing 3 changed files with 487 additions and 893 deletions.
1 change: 0 additions & 1 deletion packages/bazel/src/ngc-wrapped/index.ts
Expand Up @@ -23,7 +23,6 @@ type CompilerCliModule =
// Add devmode for blaze internal
interface BazelOptions extends ExternalBazelOptions {
allowedInputs?: string[];
devmode?: boolean;
unusedInputsListPath?: string;
}

Expand Down
2 changes: 1 addition & 1 deletion packages/localize/tools/src/source_file_utils.ts
Expand Up @@ -463,7 +463,7 @@ function getLineAndColumn(loc: {line: number, column: number}): {line: number, c
}

function getText(path: NodePath): string|undefined {
if (path.node.start === null || path.node.end === null) {
if (path.node.start == null || path.node.end == null) {
return undefined;
}
return path.hub.file.code.substring(path.node.start, path.node.end);
Expand Down

0 comments on commit 52626d8

Please sign in to comment.