Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
test: update tests to not run jasmine
done
function in sync-test zo…
…ne from `describe` block There are some ZoneJS tests that fork the zone from the `describe` block for testing the zone patching. This does cause the Jasmine `done` function later in `it` specs to be invoked in the sync-test zone from the original `describe` block. The `done` implementation now has changed with the Karma Jasmine update and breaks because it now causes tasks to be scheduled. It is conceptually incorrect/invalid to take the describe sync zone and run test logic with that sync zone. ``` An error was thrown in afterAll error properties: Object({ originalStack: 'Error: Cannot call jasmine.execute().forceTask from within a sync test (syncTestZone for jasmine.describe#FileReader). at new ZoneAwareError (packages/zone.js/test/browser_test_rollup.umd.js:98:37) at e.onScheduleTask (packages/zone.js/bundles/zone-testing-bundle.umd.min.js:158:196) at e.scheduleTask (packages/zone.js/bundles/zone-testing-bundle.umd.min.js:14:7529) at t.scheduleTask (packages/zone.js/bundles/zone-testing-bundle.umd.min.js:14:3539) at t.scheduleMicroTask (packages/zone.js/bundles/zone-testing-bundle.umd.min.js:14:3791) at r.execute (packages/zone.js/bundles/zone-testing-bundle.umd.min.js:166:4312) at queueRunnerFa ... at <Jasmine> ```
- Loading branch information