Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

fix(required): correctly validate when required #16846

Closed
wants to merge 5 commits into from

Conversation

kambleaa007
Copy link
Contributor

@kambleaa007 kambleaa007 commented Mar 5, 2019

AngularJS is in LTS mode

We are no longer accepting changes that are not critical bug fixes into this project.
See https://blog.angular.io/stable-angularjs-and-long-term-support-7e077635ee9c for more detail.

Does this PR fix a regression since 1.7.0, a security flaw, or a problem caused by a new browser version?

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change?

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Fix/Feature: Docs have been added/updated
  • Fix/Feature: Tests have been added; existing tests pass

Other information:

 chore(github): update PR template to highlight LTS mode
@kambleaa007
Copy link
Contributor Author

its same as #16836 why its not merged with master/angularjs
its make my master branch ahead of angularjs's master branch

@gkalpak
Copy link
Member

gkalpak commented Mar 5, 2019

This seems to include a change that is already in #16833, so I assume it was opened by accident.
(Note: If you want to make a change to #16833, you need to push the changes to the patch-2 branch of your remote.)

@gkalpak gkalpak closed this Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants