This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngRequired): set error correctly when inside ngRepeat and false b… #16820
+19
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Narretz
force-pushed
the
fix-ngRequired
branch
from
734bf11
to
c3ff296
Compare
gkalpak
approved these changes
Jan 21, 2019
test/ng/directive/validatorsSpec.js
Outdated
| var elm = helper.compileInput( | ||
| '<div ng-repeat="input in [0]">' + | ||
| '<input type="text" ng-ref="refs.input" ng-ref-read="ngModel" ng-model="value" ng-required="isRequired" validation-spy="required" />' | ||
| + '</div>' |
There was a problem hiding this comment.
The + sign placement seems weird (i.e. inconsistent - which is the ultimate form of weird 😛).
Did the linter have you do it like this, or is it a personal preference?
There was a problem hiding this comment.
Ha, this happened because I tested without ngRepeat, and switching between with / without is easier if the concat plusses are at the start of the line
petebacondarwin
approved these changes
Jan 23, 2019
…y default Previously, in the required validator, we would read the required setting directly from attr.required, where it is set by ngRequired. However, when the control is inside ngRepeat, ngRequired sets it only after a another digest has passed, which means the initial validation run of ngModel does not include the correct required setting. (Before commit 0637a21 this would not have been a problem, as every observed value change triggered a validation). We now use the initially parsed value from ngRequired in the validator. Fixes angular#16814
Narretz
force-pushed
the
fix-ngRequired
branch
from
c3ff296
to
42a9eca
Compare
Narretz
added a commit
that referenced
this pull request
Jan 26, 2019
…y default Previously, in the required validator, we would read the required setting directly from attr.required, where it is set by ngRequired. However, when the control is inside ngRepeat, ngRequired sets it only after a another digest has passed, which means the initial validation run of ngModel does not include the correct required setting. (Before commit 0637a21 this would not have been a problem, as every observed value change triggered a validation). We now use the initially parsed value from ngRequired in the validator. Fixes #16814 Closes #16820
This was referenced Jan 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…y default
Previously, in the required validator, we would read the required setting directly from attr.required,
where it is set by ngRequired.
However, when the control is inside ngRepeat, ngRequired sets it only after a another digest has
passed, which means the initial validation run of ngModel does not include the correct required
setting. (Before commit 0637a21 this would not have been a problem,
as every observed value change triggered a validation).
We now use the initially parsed value from ngRequired in the validator.
Fixes #16814
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change?
Please check if the PR fulfills these requirements
Other information: