Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

fix($$RAFProvider): prevent a JavaScript error in Firefox #16192

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix($$RAFProvider): prevent a JavaScript error in Firefox #16192

wants to merge 3 commits into from

Commits on Aug 23, 2017

  1. fix($$RAFProvider): prevent a JavaScript error in Firefox 

    Firefox raises a Javascript Error "TypeError: 'requestAnimationFrame' called on an object that does not implement interface Window." with animated elements. This is because Window.requestAnimationFrame() is called without binding to a Window instance in the function which is returned from $$RAFProvider().
    @dmuellner
    dmuellner committed Aug 23, 2017
    Configuration menu
    Copy the full SHA
    f709dec View commit details
    Browse the repository at this point in the history

  2. Address reviewer's comments

    @dmuellner
    dmuellner committed Aug 23, 2017
    Configuration menu
    Copy the full SHA
    10e8e48 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2017

  1. Minimal example to showcase bug.

    @dmuellner
    dmuellner committed Aug 28, 2017
    Configuration menu
    Copy the full SHA
    fa79348 View commit details
    Browse the repository at this point in the history