fix(@angular/cli): work around npm peerdep issue #9713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipesilva
force-pushed
the
ajv-peerde-workaround
branch
from
dc55b63
to
72a057a
Compare
hansl
previously approved these changes
Feb 21, 2018
| // whose workaround is to depend on AJV. | ||
| // See https://github.com/angular/angular-cli/issues/9691#issuecomment-367322703 for details. | ||
| // We need to add a require here to satisfy the dependency checker. | ||
| // require('ajv'); |
There was a problem hiding this comment.
Could you add a TODO here to make sure we get it in our reminders?
NPM hoists dependencies with peerDeps of their own, leading to unmet peer dependencies. This workaround should be safe for now since the only two packages that depend on `ajv-keywords@3.1.0` are `webpack` and `schema-utils`. See angular#9691 (comment) and npm/npm#19877 for more information. Fix angular#9691.
filipesilva
force-pushed
the
ajv-peerde-workaround
branch
from
72a057a
to
44f3c6a
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NPM hoists dependencies with peerDeps of their own, leading to unmet peer dependencies.
This workaround should be safe for now since the only two packages that depend on
ajv-keywords@3.1.0arewebpackandschema-utils.See #9691 (comment) and npm/npm#19877 for more information.
Fix #9691.