Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular/cli): exclude @angular/localize@<10.0.0 from ng add pa… #24152

Merged
merged 2 commits into from Oct 27, 2022

Commits on Oct 27, 2022

  1. fix(@angular/cli): exclude @angular/localize@<10.0.0 from ng add pa…

    …ckage discovery
    
    `@angular/localize@<10.0.0` has no peer dependencies. This can cause `ng add` to pick these versions of the package if the newer versions.
    
    See: https://app.circleci.com/pipelines/github/angular/angular-cli/27402/workflows/faa64532-541a-4bea-b599-3c53afe42019/jobs/364822
    ```
    Test Process error Error: Process exit error - "ng add @angular/localize --skip-confirmation": 1...
    
    STDOUT:
    
    STDERR:
    npm version 7.4.0 detected. When using npm 7 with the Angular CLI, npm version 7.5.6 or higher is recommended.
    - Determining package manager...
    ℹ Using package manager: npm
    - Searching for compatible package version...
    ✔ Found compatible package version: @angular/localize@10.0.0-next.7.
    - Loading package information from registry...
    ✔ Package information loaded.
    - Installing packages...
    ✔ Packages successfully installed.
    NOT SUPPORTED: keyword "id", use "$id" for schema ID
    ```
    alan-agius4 committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    79dc44e View commit details
    Browse the repository at this point in the history
  2. fixup! fix(@angular/cli): exclude @angular/localize@<10.0.0 from ng…

    … add package discovery
    
    Co-authored-by: Charles <19598772+clydin@users.noreply.github.com>
    alan-agius4 and clydin committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    5d6c45b View commit details
    Browse the repository at this point in the history