fix(@angular-devkit/build-angular): correctly extract messages when using cached build #22266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sing cached build Extracted messages are not part of Webpack pipeline and hence they cannot be retrieved from cache. Therefore, we need to mark the extraction loader as non cacheable. Closes #22264
alan-agius4
added
the
target: patch
dgp1130
approved these changes
Dec 1, 2021
packages/angular_devkit/build_angular/src/builders/extract-i18n/ivy-extract-loader.ts
Outdated
Show resolved
Hide resolved
| @@ -21,6 +21,11 @@ export default function localizeExtractLoader( | |||
| content: string, | |||
| map: LoaderSourceMap, | |||
| ) { | |||
| // This loader is not cacheable due to message extraction works. | |||
| // Extracted messages are not part of webpack pipeline and hence they cannot be retrieved from cache. | |||
| // TODO: We should investigate in the future on making this deterministic and more cacheable. | |||
There was a problem hiding this comment.
Should we file an issue or project about this? I'm always hesitant about TODO's in the code which tend to be forgotten about. Issues are more easily triaged, assignable, and actionable IMHO.
… when using cached build
alan-agius4
added
merge: squash commits
dgp1130
pushed a commit
that referenced
this pull request
Dec 1, 2021
…sing cached build (#22266) * fix(@angular-devkit/build-angular): correctly extract messages when using cached build Extracted messages are not part of Webpack pipeline and hence they cannot be retrieved from cache. Therefore, we need to mark the extraction loader as non cacheable. Closes #22264 * fixup! fix(@angular-devkit/build-angular): correctly extract messages when using cached build (cherry picked from commit 52c6c3d)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted messages are not part of Webpack pipeline and hence they cannot be retrieved from cache. Therefore, we need to mark the extraction loader as non cacheable.
Closes #22264