fixup! test: run legacy-cli e2e tests via bazel

fixup: add ChromeHeadlessNoSandbox browser to to karma builder
angular · Nov 18, 2022 · 9cf4e37 · 9cf4e37
1 parent 46561d8
commit 9cf4e37
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 27 deletions.
diff --git a/packages/angular_devkit/build_angular/src/builders/karma/index.ts b/packages/angular_devkit/build_angular/src/builders/karma/index.ts
@@ -222,6 +222,12 @@ function getBuiltInKarmaConfig(
     logLevel: karma.constants.LOG_INFO,
     autoWatch: true,
     browsers: ['Chrome'],
+    customLaunchers: {
+      ChromeHeadlessNoSandbox: {
+        base: 'ChromeHeadless',
+        flags: ['--no-sandbox', '--headless', '--disable-gpu', '--disable-dev-shm-usage'],
+      },
+    },
     restartOnFileChange: true,
   };
 }

diff --git a/tests/legacy-cli/e2e/utils/project.ts b/tests/legacy-cli/e2e/utils/project.ts
@@ -245,38 +245,11 @@ export async function useCIChrome(projectName: string, projectDir = ''): Promise
     );
   }
 
-  const karmaConf = path.join(projectDir, 'karma.conf.js');
-
-  // Create one with default config if it doesn't exist
-  if (!fs.existsSync(karmaConf)) {
-    await writeFile(karmaConf, KARMA_CONF_DEFAULT.replace('$PROJECT_NAME$', projectName));
-  }
-
   // Update to use the headless sandboxed chrome
-  await replaceInFile(
-    karmaConf,
-    /browsers:.*\]\s*,/,
-    `
-      browsers: ['ChromeHeadlessNoSandbox'],
-      customLaunchers: {
-        ChromeHeadlessNoSandbox: {
-          base: 'ChromeHeadless',
-          flags: [
-            '--no-sandbox',
-            '--headless',
-            '--disable-gpu',
-            '--disable-dev-shm-usage',
-          ],
-        }
-      },
-    `,
-  );
-
   return updateJsonFile('angular.json', (workspaceJson) => {
     const project = workspaceJson.projects[projectName];
     const appTargets = project.targets || project.architect;
     appTargets.test.options.browsers = 'ChromeHeadlessNoSandbox';
-    appTargets.test.options.karmaConfig = karmaConf;
   });
 }