Skip to content

Commit

Permalink
build: use rbe platform with network from shared dev-infra build tooling
Browse files Browse the repository at this point in the history
This avoids having to manually declare the `platform`. We specifically
added support for the network platform due to the CLI needs.

The CLI repository should long-term set
`--sandbox_default_allow_network=false` in the `bazelrc` so that
internet access is only granted targets explicitly. We should discourage
reliance on internet as much as possible to help with hermetic tests.
  • Loading branch information
devversion authored and alan-agius4 committed Jul 27, 2022
1 parent 087ab46 commit 96d39f8
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 12 deletions.
6 changes: 3 additions & 3 deletions .bazelrc
Expand Up @@ -120,9 +120,9 @@ build:remote --jobs=150
# is provided by the shared dev-infra package and targets k8 remote containers.
build:remote --crosstool_top=@npm//@angular/build-tooling/bazel/remote-execution/cpp:cc_toolchain_suite
build:remote --extra_toolchains=@npm//@angular/build-tooling/bazel/remote-execution/cpp:cc_toolchain
build:remote --extra_execution_platforms=//tools:rbe_platform_with_network_access
build:remote --host_platform=//tools:rbe_platform_with_network_access
build:remote --platforms=//tools:rbe_platform_with_network_access
build:remote --extra_execution_platforms=@npm//@angular/build-tooling/bazel/remote-execution:platform_with_network
build:remote --host_platform=@npm//@angular/build-tooling/bazel/remote-execution:platform_with_network
build:remote --platforms=@npm//@angular/build-tooling/bazel/remote-execution:platform_with_network

# Set remote caching settings
build:remote --remote_accept_cached=true
Expand Down
9 changes: 0 additions & 9 deletions tools/BUILD.bazel
Expand Up @@ -28,13 +28,4 @@ nodejs_binary(
entry_point = "quicktype_runner.js",
templated_args = ["--bazel_patch_module_resolver"],
)

platform(
name = "rbe_platform_with_network_access",
exec_properties = {
"dockerNetwork": "standard",
},
parents = ["@npm//@angular/build-tooling/bazel/remote-execution:platform"],
)

# @external_end

0 comments on commit 96d39f8

Please sign in to comment.