Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change order of line number geneartion #189

Merged
merged 1 commit into from May 12, 2019

Commits on May 9, 2019

  1. fix(ngStyle): correctly remove old style when new style value is invalid

    Since d6098ee, old styles were not removed if `newStyles` specified an
    invalid value for the style (e.g. `false`). The assumption was that the
    new style would overwrite the old style value, but using an invalid
    value made browsers ignore the new value and thus keep the old style.
    This would typically happen when guarding a style with a boolean flag;
    e.g.: `ng-style="{backgroundColor: isError && 'red'}"`
    
    This commit essentially revers commit d6098ee, whose main purpose was
    to work around jquery/jquery#4185. The jQuery issue has been fixed in
    3.4.0, so that should not be a problem any more.
    
    Fixes #16860
    
    Closes #16868
    gkalpak committed May 9, 2019
    Configuration menu
    Copy the full SHA
    10d1b19 View commit details
    Browse the repository at this point in the history