fix(eslint-plugin): [sort-ngmodule-metadata-arrays] deprecate rule #1781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 6c6e34d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targetsSent with 💌 from NxCloud. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1781 +/- ##
==========================================
+ Coverage 89.56% 90.60% +1.03%
==========================================
Files 171 176 +5
Lines 3202 3278 +76
Branches 544 536 -8
==========================================
+ Hits 2868 2970 +102
- Misses 198 201 +3
+ Partials 136 107 -29
Flags with carried forward coverage won't be shown. Click here to find out more.
|
JamesHenry
approved these changes
May 1, 2024
JamesHenry
changed the title
|
FYI updated to fix so that it shows up in the release notes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request deprecates rule
sort-ngmodule-metadata-arrays; see discussions in #1232.Because there is no replacement for this rule, this pull request also updates the rule doc generator to not include a rule replacement note if one is not available.
Closes #1232