Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependency prettier to v3.2.5 #1694

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 12, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
prettier (source) 3.1.1 -> 3.2.5 age adoption passing confidence
@​types/prettier 2.7.3 -> 3.0.0 age adoption passing confidence

Release Notes

prettier/prettier (prettier)

v3.2.5

Compare Source

diff

Support Angular inline styles as single template literal (#​15968 by @​sosukesuzuki)

Angular v17 supports single string inline styles.

// Input
@​Component({
  template: `<div>...</div>`,
  styles: `h1 { color: blue; }`,
})
export class AppComponent {}

// Prettier 3.2.4
@&#8203;Component({
  template: `<div>...</div>`,
  styles: `h1 { color: blue; }`,
})
export class AppComponent {}

// Prettier 3.2.5
@&#8203;Component({
  template: `<div>...</div>`,
  styles: `
    h1 {
      color: blue;
    }
  `,
})
export class AppComponent {}
Unexpected embedded formatting for Angular template (#​15969 by @​JounQin)

Computed template should not be considered as Angular component template

// Input
const template = "foobar";

@&#8203;Component({
  [template]: `<h1>{{       hello }}</h1>`,
})
export class AppComponent {}

// Prettier 3.2.4
const template = "foobar";

@&#8203;Component({
  [template]: `<h1>{{ hello }}</h1>`,
})
export class AppComponent {}

// Prettier 3.2.5
const template = "foobar";

@&#8203;Component({
  [template]: `<h1>{{       hello }}</h1>`,
})
export class AppComponent {}
Use "json" parser for tsconfig.json by default (#​16012 by @​sosukesuzuki)

In v2.3.0, we introduced "jsonc" parser which adds trialing comma by default.

When adding a new parser we also define how it will be used based on the linguist-languages data.

tsconfig.json is a special file used by TypeScript, it uses .json file extension, but it actually uses the JSON with Comments syntax. However, we found that there are many third-party tools not recognize it correctly because of the confusing .json file extension.

We decide to treat it as a JSON file for now to avoid the extra configuration step.

To keep using the "jsonc" parser for your tsconfig.json files, add the following to your .pretterrc file

{
  "overrides": [
    {
      "files": ["tsconfig.json", "jsconfig.json"],
      "options": {
        "parser": "jsonc"
      }
    }
  ]
}

v3.2.4

Compare Source

diff

Fix incorrect parser inference (#​15947 by @​fisker)

Files like .eslintrc.json were incorrectly formatted as JSONC files.

// Input
prettier --file-info .eslintrc.json
{ "ignored": false, "inferredParser": "jsonc" }

// Prettier 3.2.4
prettier --file-info .eslintrc.json
{ "ignored": false, "inferredParser": "json" }

v3.2.3

Compare Source

diff

Throw errors for invalid code (#​15881 by @​fisker, @​Josh-Cena, @​auvred)
// Input
1++;

// Prettier 3.2.2
1++;

// Prettier 3.2.3
SyntaxError: Invalid left-hand side expression in unary operation (1:1)
> 1 | 1++;
    | ^
// Input
try {} catch (error = 1){}

// Prettier 3.2.2
try {
} catch (error) {}

// Prettier 3.2.3
SyntaxError: Catch clause variable cannot have an initializer. (1:23)
> 1 | try {} catch (error = 1){}
    |                       ^
Fix parser inference (#​15927 by @​fisker)
// Prettier 3.2.2
prettier --file-info tsconfig.json
{ "ignored": false, "inferredParser": "json" }

// Prettier 3.2.3
prettier --file-info tsconfig.json
{ "ignored": false, "inferredParser": "jsonc" }

v3.2.2

Compare Source

diff

Fix crash when parsing template literal CSS in a JSX style tag using a spread attribute (#​15896 by @​eelco)

For example this code would crash before:

<style {...spread}>{`.{}`}</style>
Fix formatting error on optional call expression and member chain (#​15920 by @​sosukesuzuki)
// Input
a(() => {}, c?.d());

// Prettier 3.2.1
TypeError: Cannot read properties of undefined (reading 'type')

// Prettier 3.2.2
a(() => {}, c?.d());

v3.2.1

Compare Source

diff

Fix formatting error on member chain (#​15915 by @​sosukesuzuki)
// Input
test().test2().test2(thing?.something);

// Prettier 3.2.0
TypeError: Cannot read properties of undefined (reading 'type')

// Prettier 3.2.1
test().test2().test2(thing?.something);

v3.2.0

Compare Source

diff

🔗 Release Notes


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

Copy link

nx-cloud bot commented Jan 12, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 198311b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx-cloud record -- yarn format-check
✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

@renovate renovate bot changed the title chore: update dependency prettier to v3.2.0 chore: update dependency prettier to v3.2.1 Jan 12, 2024
@renovate renovate bot changed the title chore: update dependency prettier to v3.2.1 chore: update dependency prettier to v3.2.2 Jan 14, 2024
@renovate renovate bot changed the title chore: update dependency prettier to v3.2.2 chore: update dependency prettier to v3.2.3 Jan 17, 2024
@renovate renovate bot force-pushed the renovate/prettier-3.x branch 2 times, most recently from 456dcc1 to b6a9d3d Compare January 17, 2024 14:20
@renovate renovate bot changed the title chore: update dependency prettier to v3.2.3 chore: update dependency prettier to v3.2.4 Jan 17, 2024
@renovate renovate bot force-pushed the renovate/prettier-3.x branch 11 times, most recently from d69887b to 715225e Compare January 20, 2024 19:18
@JamesHenry JamesHenry added the invalid This doesn't seem right label Jan 20, 2024
@JamesHenry JamesHenry marked this pull request as draft January 20, 2024 19:46
@JamesHenry
Copy link
Member

Blocking until prettier/prettier#15956 hopefully gets addressed

Copy link
Member

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

@renovate renovate bot force-pushed the renovate/prettier-3.x branch 4 times, most recently from a5b183d to 3f8c4aa Compare January 21, 2024 14:05
@renovate renovate bot changed the title chore: update dependency prettier to v3.2.4 chore: update dependency prettier to v3.2.5 Feb 4, 2024
@renovate renovate bot force-pushed the renovate/prettier-3.x branch 4 times, most recently from 8ffda58 to 3fd94a4 Compare March 20, 2024 16:11
@renovate renovate bot force-pushed the renovate/prettier-3.x branch 13 times, most recently from dd4fd58 to f2d6951 Compare April 18, 2024 13:00
@renovate renovate bot force-pushed the renovate/prettier-3.x branch 10 times, most recently from fe26b50 to 8b7488d Compare May 3, 2024 15:35
@renovate renovate bot force-pushed the renovate/prettier-3.x branch from 8b7488d to 198311b Compare May 7, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant