New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(angular-eslint): ignore hostDirectives for no-output-rename and no-outputs-metadata-property #1466
fix(angular-eslint): ignore hostDirectives for no-output-rename and no-outputs-metadata-property #1466
Conversation
…irective composition API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @profanis!
Looks like the tests are failing currently
I've fixed the tests @JamesHenry |
Codecov Report
@@ Coverage Diff @@
## main #1466 +/- ##
==========================================
- Coverage 89.32% 89.23% -0.10%
==========================================
Files 162 162
Lines 3045 3056 +11
Branches 515 521 +6
==========================================
+ Hits 2720 2727 +7
Misses 201 201
- Partials 124 128 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Thank you @profanis! |
…o-outputs-metadata-property (angular-eslint#1466)
I noticed that there are cases for the
no-input-rename
#1231 andno-inputs-metadata-property
#1248, but there are no cases for theno-output-rename
andno-outputs-metadata-property
.This PR has code almost identical ("borrowed" 🤭) from the above-mentioned PRs