Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular-eslint): ignore hostDirectives for no-output-rename and no-outputs-metadata-property #1466

Conversation

profanis
Copy link
Contributor

@profanis profanis commented Aug 1, 2023

I noticed that there are cases for the no-input-rename #1231 and no-inputs-metadata-property #1248, but there are no cases for the no-output-rename and no-outputs-metadata-property.

This PR has code almost identical ("borrowed" 🤭) from the above-mentioned PRs

@JamesHenry JamesHenry changed the title fix(angular-eslint): no output rename and metadata property fix(angular-eslint): ignore hostDirectives for no-output-rename and no-outputs-metadata-property Aug 19, 2023
Copy link
Member

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @profanis!

Looks like the tests are failing currently

@profanis
Copy link
Contributor Author

Thanks @profanis!

Looks like the tests are failing currently

I've fixed the tests @JamesHenry

@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #1466 (69c90a8) into main (471d6ad) will decrease coverage by 0.10%.
The diff coverage is 91.66%.

@@            Coverage Diff             @@
##             main    #1466      +/-   ##
==========================================
- Coverage   89.32%   89.23%   -0.10%     
==========================================
  Files         162      162              
  Lines        3045     3056      +11     
  Branches      515      521       +6     
==========================================
+ Hits         2720     2727       +7     
  Misses        201      201              
- Partials      124      128       +4     
Flag Coverage Δ
unittest 89.23% <91.66%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...slint-plugin/tests/rules/no-output-rename/cases.ts 100.00% <ø> (ø)
.../tests/rules/no-outputs-metadata-property/cases.ts 100.00% <ø> (ø)
...t-plugin/src/rules/no-outputs-metadata-property.ts 87.50% <83.33%> (-12.50%) ⬇️
...ckages/eslint-plugin/src/rules/no-output-rename.ts 90.69% <100.00%> (-4.04%) ⬇️

@JamesHenry JamesHenry merged commit 208bf25 into angular-eslint:main Aug 21, 2023
13 checks passed
@JamesHenry
Copy link
Member

Thank you @profanis!

strawberry-choco pushed a commit to strawberry-choco/angular-eslint that referenced this pull request Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants