Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(builder): ensure package works with Angular 14.1.3 #1112

Merged
merged 1 commit into from Aug 23, 2022
Merged

fix(builder): ensure package works with Angular 14.1.3 #1112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 9 additions & 9 deletions package.json
View file
Open in desktop
Expand Up @@ -53,15 +53,15 @@
"devDependencies": {
"@actions/core": "1.9.0",
"@actions/github": "5.0.3",
"@angular/cli": "14.0.0",
"@angular/compiler": "14.0.0",
"@angular/cli": "14.1.3",
"@angular/compiler": "14.1.3",
"@commitlint/cli": "17.0.2",
"@commitlint/config-conventional": "17.0.2",
"@nrwl/devkit": "14.4.2",
"@nrwl/jest": "14.4.2",
"@nrwl/nx-cloud": "14.2.0",
"@nrwl/workspace": "14.4.2",
"@schematics/angular": "14.0.0",
"@nrwl/devkit": "14.5.9",
"@nrwl/jest": "14.5.9",
"@nrwl/nx-cloud": "14.4.1",
"@nrwl/workspace": "14.5.9",
"@schematics/angular": "14.1.3",
"@types/eslint": "8.4.3",
"@types/eslint-scope": "3.7.3",
"@types/jest": "28.1.1",
Expand All @@ -82,14 +82,14 @@
"lint-staged": "13.0.2",
"microbundle": "0.15.0",
"ncp": "2.0.0",
"nx": "14.4.2",
"nx": "14.5.9",
"prettier": "2.7.1",
"rimraf": "3.0.2",
"strip-ansi": "6.0.1",
"terser": "5.14.1",
"tree-kill": "1.2.2",
"ts-jest": "28.0.4",
"ts-node": "10.8.1",
"ts-node": "10.9.1",
"typescript": "4.7.4"
}
}
4 changes: 2 additions & 2 deletions packages/builder/package.json
View file
Open in desktop
Expand Up @@ -19,8 +19,8 @@
],
"builders": "./builders.json",
"dependencies": {
"@nrwl/devkit": "^14.2.4",
"nx": "^14.2.4"
"@nrwl/devkit": "^14.5.9",
"nx": "^14.5.9"
},
"peerDependencies": {
"eslint": "^7.0.0 || ^8.0.0",
Expand Down
14 changes: 7 additions & 7 deletions ...__snapshots__/v13-new-workspace-create-application-false-ng-add-then-project.test.ts.snap
View file
Open in desktop
Expand Up @@ -2,24 +2,24 @@

exports[`v13-new-workspace-create-application-false-ng-add-then-project it should pass linting when adding a project before running ng-add 2`] = `
Object {
"@angular-devkit/build-angular": "^14.0.5",
"@angular-devkit/build-angular": "^14.1.3",
"@angular-eslint/builder": "9999.0.1-local-integration-tests",
"@angular-eslint/eslint-plugin": "9999.0.1-local-integration-tests",
"@angular-eslint/eslint-plugin-template": "9999.0.1-local-integration-tests",
"@angular-eslint/schematics": "9999.0.1-local-integration-tests",
"@angular-eslint/template-parser": "9999.0.1-local-integration-tests",
"@angular/cli": "~14.0.0",
"@angular/compiler-cli": "^14.0.0",
"@angular/cli": "~14.1.3",
"@angular/compiler-cli": "^14.1.0",
"@types/jasmine": "~4.0.0",
"@typescript-eslint/eslint-plugin": "5.29.0",
"@typescript-eslint/parser": "5.29.0",
"eslint": "^8.18.0",
"jasmine-core": "~4.1.0",
"karma": "~6.3.0",
"jasmine-core": "~4.2.0",
"karma": "~6.4.0",
"karma-chrome-launcher": "~3.1.0",
"karma-coverage": "~2.2.0",
"karma-jasmine": "~5.0.0",
"karma-jasmine-html-reporter": "~1.7.0",
"karma-jasmine": "~5.1.0",
"karma-jasmine-html-reporter": "~2.0.0",
"typescript": "~4.7.2",
}
`;
Expand Down
14 changes: 7 additions & 7 deletions ...__snapshots__/v13-new-workspace-create-application-false-project-then-ng-add.test.ts.snap
View file
Open in desktop
Expand Up @@ -2,24 +2,24 @@

exports[`v13-new-workspace-create-application-false-project-then-ng-add it should pass linting when ng-add is run before adding a project 2`] = `
Object {
"@angular-devkit/build-angular": "^14.0.5",
"@angular-devkit/build-angular": "^14.1.3",
"@angular-eslint/builder": "9999.0.1-local-integration-tests",
"@angular-eslint/eslint-plugin": "9999.0.1-local-integration-tests",
"@angular-eslint/eslint-plugin-template": "9999.0.1-local-integration-tests",
"@angular-eslint/schematics": "9999.0.1-local-integration-tests",
"@angular-eslint/template-parser": "9999.0.1-local-integration-tests",
"@angular/cli": "~14.0.0",
"@angular/compiler-cli": "^14.0.0",
"@angular/cli": "~14.1.3",
"@angular/compiler-cli": "^14.1.0",
"@types/jasmine": "~4.0.0",
"@typescript-eslint/eslint-plugin": "5.29.0",
"@typescript-eslint/parser": "5.29.0",
"eslint": "^8.18.0",
"jasmine-core": "~4.1.0",
"karma": "~6.3.0",
"jasmine-core": "~4.2.0",
"karma": "~6.4.0",
"karma-chrome-launcher": "~3.1.0",
"karma-coverage": "~2.2.0",
"karma-jasmine": "~5.0.0",
"karma-jasmine-html-reporter": "~1.7.0",
"karma-jasmine": "~5.1.0",
"karma-jasmine-html-reporter": "~2.0.0",
"typescript": "~4.7.2",
}
`;
Expand Down
16 changes: 8 additions & 8 deletions packages/integration-tests/tests/__snapshots__/v13-new-workspace.test.ts.snap
View file
Open in desktop
Expand Up @@ -2,25 +2,25 @@

exports[`v13-new-workspace it should pass linting after creating a new workspace from scratch using @angular-eslint 2`] = `
Object {
"@angular-devkit/build-angular": "^14.0.0",
"@angular-devkit/build-angular": "^14.1.3",
"@angular-eslint/builder": "9999.0.1-local-integration-tests",
"@angular-eslint/eslint-plugin": "9999.0.1-local-integration-tests",
"@angular-eslint/eslint-plugin-template": "9999.0.1-local-integration-tests",
"@angular-eslint/schematics": "9999.0.1-local-integration-tests",
"@angular-eslint/template-parser": "9999.0.1-local-integration-tests",
"@angular/cli": "~14.0.0",
"@angular/compiler-cli": "^14.0.0",
"@angular/cli": "~14.1.3",
"@angular/compiler-cli": "^14.1.0",
"@types/jasmine": "~4.0.0",
"@typescript-eslint/eslint-plugin": "5.29.0",
"@typescript-eslint/parser": "5.29.0",
"eslint": "^8.18.0",
"jasmine-core": "~4.1.0",
"karma": "~6.3.0",
"jasmine-core": "~4.2.0",
"karma": "~6.4.0",
"karma-chrome-launcher": "~3.1.0",
"karma-coverage": "~2.2.0",
"karma-jasmine": "~5.0.0",
"karma-jasmine-html-reporter": "~1.7.0",
"ng-packagr": "^14.0.0",
"karma-jasmine": "~5.1.0",
"karma-jasmine-html-reporter": "~2.0.0",
"ng-packagr": "^14.1.0",
"typescript": "~4.7.2",
}
`;
Expand Down
1 change: 0 additions & 1 deletion packages/schematics/src/library/schema.json
View file
Open in desktop
Expand Up @@ -4,7 +4,6 @@
"title": "Library Options Schema",
"type": "object",
"description": "Creates a new, generic library project in the current workspace.",
"long-description": "./library-long.md",
"additionalProperties": false,
"properties": {
"name": {
Expand Down