Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(no-input-rename): allow input aliases that match the directive na… #1207

Conversation

abaran30
Copy link
Contributor

@abaran30 abaran30 commented Nov 17, 2022

…me applied to an element

This pull request enhances the no-input-rename rule to allow input aliases that match the directive name applied to an element.

Example:

@Directive({
  selector: 'img[fooDirective]'
})
class Test {
  @Input('fooDirective') foo: Foo;
}

Resolves #978

Note: No new suggestions have been added for this enhancement because the rule already allows input aliases that match the directive name (when not applied to an element).

@JamesHenry JamesHenry force-pushed the fix/no-input-rename-directive-on-element branch from a776580 to 81012f9 Compare November 20, 2022 09:49
Copy link
Member

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @adbaran1!

@JamesHenry JamesHenry enabled auto-merge (squash) November 20, 2022 09:50
@codecov
Copy link

codecov bot commented Nov 20, 2022

Codecov Report

Merging #1207 (81012f9) into main (1c356ec) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1207      +/-   ##
==========================================
+ Coverage   88.14%   88.16%   +0.01%     
==========================================
  Files         161      161              
  Lines        3088     3093       +5     
  Branches      499      500       +1     
==========================================
+ Hits         2722     2727       +5     
  Misses        253      253              
  Partials      113      113              
Flag Coverage Δ
unittest 88.16% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...eslint-plugin/tests/rules/no-input-rename/cases.ts 100.00% <ø> (ø)
...ackages/eslint-plugin/src/rules/no-input-rename.ts 91.30% <100.00%> (+0.82%) ⬆️

@JamesHenry JamesHenry merged commit aff3344 into angular-eslint:main Nov 20, 2022
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Nov 28, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@angular-eslint/builder](https://github.com/angular-eslint/angular-eslint) | devDependencies | minor | [`14.2.0` -> `14.4.0`](https://renovatebot.com/diffs/npm/@angular-eslint%2fbuilder/14.2.0/14.4.0) |
| [@angular-eslint/eslint-plugin](https://github.com/angular-eslint/angular-eslint) | devDependencies | minor | [`14.2.0` -> `14.4.0`](https://renovatebot.com/diffs/npm/@angular-eslint%2feslint-plugin/14.2.0/14.4.0) |
| [@angular-eslint/eslint-plugin-template](https://github.com/angular-eslint/angular-eslint) | devDependencies | minor | [`14.2.0` -> `14.4.0`](https://renovatebot.com/diffs/npm/@angular-eslint%2feslint-plugin-template/14.2.0/14.4.0) |
| [@angular-eslint/schematics](https://github.com/angular-eslint/angular-eslint) | devDependencies | minor | [`14.2.0` -> `14.4.0`](https://renovatebot.com/diffs/npm/@angular-eslint%2fschematics/14.2.0/14.4.0) |
| [@angular-eslint/template-parser](https://github.com/angular-eslint/angular-eslint) | devDependencies | minor | [`14.2.0` -> `14.4.0`](https://renovatebot.com/diffs/npm/@angular-eslint%2ftemplate-parser/14.2.0/14.4.0) |

---

### Release Notes

<details>
<summary>angular-eslint/angular-eslint (@&#8203;angular-eslint/builder)</summary>

### [`v14.4.0`](https://github.com/angular-eslint/angular-eslint/blob/HEAD/packages/builder/CHANGELOG.md#&#8203;1440-httpsgithubcomangular-eslintangular-eslintcomparev1431v1440-2022-11-20)

[Compare Source](angular-eslint/angular-eslint@v14.3.1...v14.4.0)

**Note:** Version bump only for package [@&#8203;angular-eslint/builder](https://github.com/angular-eslint/builder)

#### [14.3.1](angular-eslint/angular-eslint@v14.3.0...v14.3.1) (2022-11-20)

**Note:** Version bump only for package [@&#8203;angular-eslint/builder](https://github.com/angular-eslint/builder)

### [`v14.3.1`](https://github.com/angular-eslint/angular-eslint/blob/HEAD/packages/builder/CHANGELOG.md#&#8203;1431-httpsgithubcomangular-eslintangular-eslintcomparev1430v1431-2022-11-20)

[Compare Source](angular-eslint/angular-eslint@v14.3.0...v14.3.1)

**Note:** Version bump only for package [@&#8203;angular-eslint/builder](https://github.com/angular-eslint/builder)

### [`v14.3.0`](https://github.com/angular-eslint/angular-eslint/blob/HEAD/packages/builder/CHANGELOG.md#&#8203;1430-httpsgithubcomangular-eslintangular-eslintcomparev1420v1430-2022-11-17)

[Compare Source](angular-eslint/angular-eslint@v14.2.0...v14.3.0)

**Note:** Version bump only for package [@&#8203;angular-eslint/builder](https://github.com/angular-eslint/builder)

</details>

<details>
<summary>angular-eslint/angular-eslint (@&#8203;angular-eslint/eslint-plugin)</summary>

### [`v14.4.0`](https://github.com/angular-eslint/angular-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#&#8203;1440-httpsgithubcomangular-eslintangular-eslintcomparev1431v1440-2022-11-20)

[Compare Source](angular-eslint/angular-eslint@v14.3.1...v14.4.0)

**Note:** Version bump only for package [@&#8203;angular-eslint/eslint-plugin](https://github.com/angular-eslint/eslint-plugin)

#### [14.3.1](angular-eslint/angular-eslint@v14.3.0...v14.3.1) (2022-11-20)

##### Bug Fixes

-   **no-input-rename:** allow input aliases that match the directive name applied to an element ([#&#8203;1207](angular-eslint/angular-eslint#1207)) ([aff3344](angular-eslint/angular-eslint@aff3344))

### [`v14.3.1`](https://github.com/angular-eslint/angular-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#&#8203;1431-httpsgithubcomangular-eslintangular-eslintcomparev1430v1431-2022-11-20)

[Compare Source](angular-eslint/angular-eslint@v14.3.0...v14.3.1)

##### Bug Fixes

-   **no-input-rename:** allow input aliases that match the directive name applied to an element ([#&#8203;1207](angular-eslint/angular-eslint#1207)) ([aff3344](angular-eslint/angular-eslint@aff3344))

### [`v14.3.0`](https://github.com/angular-eslint/angular-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#&#8203;1430-httpsgithubcomangular-eslintangular-eslintcomparev1420v1430-2022-11-17)

[Compare Source](angular-eslint/angular-eslint@v14.2.0...v14.3.0)

**Note:** Version bump only for package [@&#8203;angular-eslint/eslint-plugin](https://github.com/angular-eslint/eslint-plugin)

</details>

<details>
<summary>angular-eslint/angular-eslint (@&#8203;angular-eslint/eslint-plugin-template)</summary>

### [`v14.4.0`](https://github.com/angular-eslint/angular-eslint/blob/HEAD/packages/eslint-plugin-template/CHANGELOG.md#&#8203;1440-httpsgithubcomangular-eslintangular-eslintcomparev1431v1440-2022-11-20)

[Compare Source](angular-eslint/angular-eslint@v14.3.1...v14.4.0)

##### Features

-   **utils:** export template parser services ([#&#8203;1211](angular-eslint/angular-eslint#1211)) ([34a62d2](angular-eslint/angular-eslint@34a62d2))

#### [14.3.1](angular-eslint/angular-eslint@v14.3.0...v14.3.1) (2022-11-20)

**Note:** Version bump only for package [@&#8203;angular-eslint/eslint-plugin-template](https://github.com/angular-eslint/eslint-plugin-template)

### [`v14.3.1`](https://github.com/angular-eslint/angular-eslint/blob/HEAD/packages/eslint-plugin-template/CHANGELOG.md#&#8203;1431-httpsgithubcomangular-eslintangular-eslintcomparev1430v1431-2022-11-20)

[Compare Source](angular-eslint/angular-eslint@v14.3.0...v14.3.1)

**Note:** Version bump only for package [@&#8203;angular-eslint/eslint-plugin-template](https://github.com/angular-eslint/eslint-plugin-template)

### [`v14.3.0`](https://github.com/angular-eslint/angular-eslint/blob/HEAD/packages/eslint-plugin-template/CHANGELOG.md#&#8203;1430-httpsgithubcomangular-eslintangular-eslintcomparev1420v1430-2022-11-17)

[Compare Source](angular-eslint/angular-eslint@v14.2.0...v14.3.0)

##### Features

-   **eslint-plugin-template:** \[accessibility-elements-content] add allowList option ([#&#8203;1201](angular-eslint/angular-eslint#1201)) ([3877f43](angular-eslint/angular-eslint@3877f43))
-   **eslint-plugin-template:** \[no-inline-styles] add rule ([#&#8203;1162](angular-eslint/angular-eslint#1162)) ([7e1aadf](angular-eslint/angular-eslint@7e1aadf))

</details>

<details>
<summary>angular-eslint/angular-eslint (@&#8203;angular-eslint/schematics)</summary>

### [`v14.4.0`](https://github.com/angular-eslint/angular-eslint/blob/HEAD/packages/schematics/CHANGELOG.md#&#8203;1440-httpsgithubcomangular-eslintangular-eslintcomparev1431v1440-2022-11-20)

[Compare Source](angular-eslint/angular-eslint@v14.3.1...v14.4.0)

**Note:** Version bump only for package [@&#8203;angular-eslint/schematics](https://github.com/angular-eslint/schematics)

#### [14.3.1](angular-eslint/angular-eslint@v14.3.0...v14.3.1) (2022-11-20)

##### Bug Fixes

-   update dependency eslint to v8.28.0 ([#&#8203;1210](angular-eslint/angular-eslint#1210)) ([c671e74](angular-eslint/angular-eslint@c671e74))

### [`v14.3.1`](https://github.com/angular-eslint/angular-eslint/blob/HEAD/packages/schematics/CHANGELOG.md#&#8203;1431-httpsgithubcomangular-eslintangular-eslintcomparev1430v1431-2022-11-20)

[Compare Source](angular-eslint/angular-eslint@v14.3.0...v14.3.1)

##### Bug Fixes

-   update dependency eslint to v8.28.0 ([#&#8203;1210](angular-eslint/angular-eslint#1210)) ([c671e74](angular-eslint/angular-eslint@c671e74))

### [`v14.3.0`](https://github.com/angular-eslint/angular-eslint/blob/HEAD/packages/schematics/CHANGELOG.md#&#8203;1430-httpsgithubcomangular-eslintangular-eslintcomparev1420v1430-2022-11-17)

[Compare Source](angular-eslint/angular-eslint@v14.2.0...v14.3.0)

**Note:** Version bump only for package [@&#8203;angular-eslint/schematics](https://github.com/angular-eslint/schematics)

</details>

<details>
<summary>angular-eslint/angular-eslint (@&#8203;angular-eslint/template-parser)</summary>

### [`v14.4.0`](https://github.com/angular-eslint/angular-eslint/blob/HEAD/packages/template-parser/CHANGELOG.md#&#8203;1440-httpsgithubcomangular-eslintangular-eslintcomparev1431v1440-2022-11-20)

[Compare Source](angular-eslint/angular-eslint@v14.3.1...v14.4.0)

**Note:** Version bump only for package [@&#8203;angular-eslint/template-parser](https://github.com/angular-eslint/template-parser)

#### [14.3.1](angular-eslint/angular-eslint@v14.3.0...v14.3.1) (2022-11-20)

**Note:** Version bump only for package [@&#8203;angular-eslint/template-parser](https://github.com/angular-eslint/template-parser)

### [`v14.3.1`](https://github.com/angular-eslint/angular-eslint/blob/HEAD/packages/template-parser/CHANGELOG.md#&#8203;1431-httpsgithubcomangular-eslintangular-eslintcomparev1430v1431-2022-11-20)

[Compare Source](angular-eslint/angular-eslint@v14.3.0...v14.3.1)

**Note:** Version bump only for package [@&#8203;angular-eslint/template-parser](https://github.com/angular-eslint/template-parser)

### [`v14.3.0`](https://github.com/angular-eslint/angular-eslint/blob/HEAD/packages/template-parser/CHANGELOG.md#&#8203;1430-httpsgithubcomangular-eslintangular-eslintcomparev1420v1430-2022-11-17)

[Compare Source](angular-eslint/angular-eslint@v14.2.0...v14.3.0)

**Note:** Version bump only for package [@&#8203;angular-eslint/template-parser](https://github.com/angular-eslint/template-parser)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4yNi4zIiwidXBkYXRlZEluVmVyIjoiMzQuMjkuMiJ9-->

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1648
Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[no-input-rename] False positive when directive apply on specific selector
2 participants