Skip to content

Commit

Permalink
feat(eslint-plugin): remove no-conflicting-lifecycle from recommended…
Browse files Browse the repository at this point in the history
… config

The no-conflicting-lifecycle rule has been shown to be unreliable at enforcing its intended purpose,
it is therefore not recommended for all workspaces.

BREAKING CHANGE: no-conflicting-lifecycle is no longer included as part of the recommended config
and if you wish to continue using it you will need to enable it yourself in your eslint config rules

re #502
  • Loading branch information
JamesHenry committed Nov 17, 2022
1 parent eef3b25 commit 19dd177
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
1 change: 0 additions & 1 deletion packages/eslint-plugin/src/configs/recommended.json
Expand Up @@ -4,7 +4,6 @@
"@angular-eslint/component-class-suffix": "error",
"@angular-eslint/contextual-lifecycle": "error",
"@angular-eslint/directive-class-suffix": "error",
"@angular-eslint/no-conflicting-lifecycle": "error",
"@angular-eslint/no-empty-lifecycle-method": "error",
"@angular-eslint/no-host-metadata-property": "error",
"@angular-eslint/no-input-rename": "error",
Expand Down
Expand Up @@ -25,7 +25,7 @@ export default createESLintRule<Options, MessageIds>({
docs: {
description:
'Ensures that directives not implement conflicting lifecycle interfaces.',
recommended: 'error',
recommended: false,
},
schema: [],
messages: {
Expand Down

0 comments on commit 19dd177

Please sign in to comment.