Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SYSENG-1727: Rework virtual server resource #154

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

SYSENG-1727: Rework virtual server resource #154

wants to merge 1 commit into from

Conversation

anx-mschaefer
Copy link
Contributor

Description

Checklist

  • added release notes to Unreleased section in CHANGELOG.md, if user facing change

References

Community Note

  • Please vote on this issue by adding a 馃憤 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@anx-mschaefer anx-mschaefer self-assigned this Jan 30, 2024
@anx-mschaefer anx-mschaefer force-pushed the SYSENG-1727/rework-virtual-server-resource branch 12 times, most recently from f0585db to 365bfbc Compare March 5, 2024 07:37
@anx-mschaefer anx-mschaefer force-pushed the SYSENG-1727/rework-virtual-server-resource branch 3 times, most recently from a8bfe18 to 4944420 Compare March 18, 2024 07:54
89Q12
89Q12 reviewed Mar 18, 2024
View reviewed changes
Copy link
Member

@89Q12 89Q12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments/questions otherwise it looks okay

docs/resources/virtual_server.md Outdated Show resolved Hide resolved
docs/resources/virtual_server.md Show resolved Hide resolved
internal/provider/virtual_server_resource_test.go Outdated Show resolved Hide resolved
@anx-mschaefer anx-mschaefer force-pushed the SYSENG-1727/rework-virtual-server-resource branch 2 times, most recently from 17d1cdb to 6adfb32 Compare March 18, 2024 09:38
@anx-mschaefer anx-mschaefer force-pushed the SYSENG-1727/rework-virtual-server-resource branch from 6adfb32 to 457f078 Compare March 19, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@89Q12 89Q12 89Q12 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@anx-mschaefer anx-mschaefer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anx-mschaefer @89Q12