Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SYSENG-1658: add e5e resources #142

Merged
merged 1 commit into from
Mar 19, 2024
Merged

SYSENG-1658: add e5e resources #142

merged 1 commit into from
Mar 19, 2024

Conversation

anx-mschaefer
Copy link
Contributor

@anx-mschaefer anx-mschaefer commented Nov 15, 2023 •
edited

Description

Checklist

  • added release notes to Unreleased section in CHANGELOG.md, if user facing change

References

Community Note

  • Please vote on this issue by adding a 馃憤 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@anx-mschaefer anx-mschaefer self-assigned this Nov 15, 2023
@anx-mschaefer anx-mschaefer force-pushed the SYSENG-1658/add-e5e-resources branch 5 times, most recently from ffd8dae to b3636ba Compare November 15, 2023 10:53
@anx-mschaefer
Copy link
Contributor Author

anx-mschaefer commented Nov 15, 2023 •
edited

89Q12
89Q12 reviewed Nov 16, 2023
View reviewed changes
Copy link
Member

@89Q12 89Q12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add to the docs that one of the storage backends is mandatory.
Otherwise LGTM

89Q12
89Q12 previously approved these changes Nov 16, 2023
View reviewed changes
89Q12
89Q12 previously approved these changes Nov 20, 2023
View reviewed changes
@anx-mschaefer anx-mschaefer force-pushed the SYSENG-1658/add-e5e-resources branch 4 times, most recently from 3ea3bd8 to 4f301d2 Compare March 12, 2024 12:33
@anx-mschaefer anx-mschaefer marked this pull request as ready for review March 12, 2024 12:41
89Q12
89Q12 previously approved these changes Mar 12, 2024
View reviewed changes
@anx-mschaefer anx-mschaefer merged commit 1eb8516 into main Mar 19, 2024
4 of 6 checks passed
@anx-mschaefer anx-mschaefer deleted the SYSENG-1658/add-e5e-resources branch March 19, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@89Q12 89Q12 89Q12 left review comments

Assignees

@anx-mschaefer anx-mschaefer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anx-mschaefer @89Q12