Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): Bearer Auth Support (oauth 2.0) #397

Merged
merged 1 commit into from Feb 18, 2022

Conversation

Chhekur
Copy link
Contributor

@Chhekur Chhekur commented Aug 25, 2021

Description

Please describe what does this Pull Request fix or add?.

Information that is useful here:

  • The What: Adding support for Bearer based auth method
  • The Why: Now user can authenticate the client with Bearer token too
  • Type of change: New Feature
  • Breaking change: no
  • Related to an issue: Not sure
  • Jira Version + Type: Both

Example:

Let us know how users can use or test this functionality.

tp := jira.BearerAuthTransport {
  Token: "<Bearer Token>"
}

jiraClient, err := jira.NewClient(tp.Client(), host)

Checklist

@andygrunwald
Copy link
Owner

Hey @Chhekur,

thanks for your pull request and the effort you put in.
I just want to drop an FYI that we, the maintainers, are quite limited in time right now, due to other obligations. It will take some time to look into this PR and move on. Thanks for understanding and your patience.

@Chhekur Chhekur force-pushed the chhekur-add-bearer-auth branch 2 times, most recently from acfc853 to 4d3a861 Compare August 27, 2021 08:19
@afdesk
Copy link

afdesk commented Oct 27, 2021

Hi @andygrunwald!
thanks for your library, it's really useful!

but we have the issue with Jira Server (DC), we need the bearer token for auth.

Is there a way to speed this PR?
thanks! look forward your decision.

@andygrunwald
Copy link
Owner

Hey @afdesk,
right now, my time is quite limited to work on this library.
We are looking for sponsors to fund the work and shift it to a more sustainable project.
As you can see we have a few Pull Requests piling up and the library needs a couple of improvements.

I (and the team) need a bit more time to go through it.
If you are interested in funding this Pull Request or the development in general, this would speed this up (mainly it allows us to prioritize this work over other work). Just contact me at andygrunwald+github (at) gmail (dot). com

@Chhekur
Copy link
Contributor Author

Chhekur commented Nov 12, 2021

Hi @andygrunwald! thanks for your library, it's really useful!

but we have the issue with Jira Server (DC), we need the bearer token for auth.

Is there a way to speed this PR? thanks! look forward your decision.

Hey, we started maintaining the fork of this library and we update the library very frequently.
so if you still looking for this change you can use our fork for the same and request for new features as well if you want.

https://github.com/interviewstreet/go-jira

@benjivesterby
Copy link
Collaborator

@Chhekur can you please rebase this on current master branch so I can merge this?

@Chhekur
Copy link
Contributor Author

Chhekur commented Feb 18, 2022

@Chhekur can you please rebase this on current master branch so I can merge this?

Hey @benjivesterby,
I rebase it with the current master branch.

@benjivesterby benjivesterby merged commit 8413325 into andygrunwald:master Feb 18, 2022
@priteau
Copy link

priteau commented Feb 21, 2022

@benjivesterby, I don't think you should have merged this, since it duplicates the PATAuthTransport feature already added in #422.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants