Fire change so we save when a preference is removed

Fixes fyne-io#3229
andydotxyz · Aug 29, 2022 · 18c64ae · 18c64ae
1 parent bcc5a30
commit 18c64ae
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/internal/preferences.go b/internal/preferences.go
@@ -73,9 +73,10 @@ func (p *InMemoryPreferences) get(key string) (interface{}, bool) {
 
 func (p *InMemoryPreferences) remove(key string) {
 	p.lock.Lock()
-	defer p.lock.Unlock()
-
 	delete(p.values, key)
+	p.lock.Unlock()
+
+	p.fireChange()
 }
 
 func (p *InMemoryPreferences) fireChange() {

diff --git a/internal/preferences_test.go b/internal/preferences_test.go
@@ -141,7 +141,11 @@ func TestInMemoryPreferences_OnChange(t *testing.T) {
 
 	p.SetString("dummy", "another")
 	time.Sleep(time.Millisecond * 100)
+	assert.True(t, called)
 
+	called = false
+	p.RemoveValue("dummy")
+	time.Sleep(time.Millisecond * 100)
 	assert.True(t, called)
 }