Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow LoadControl.shouldContinueLoading accept playWhenReady as a parameter #1339

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

colinkho
Copy link

@colinkho colinkho commented May 3, 2024

Motivation: Load Control requires different min and max buffer values depending if the player is playing or paused.

Copy link

google-cla bot commented May 3, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@colinkho colinkho force-pushed the set-play-when-ready-load-control-branch branch from 9580a7c to ef5e4de Compare May 3, 2024 06:25
@colinkho
Copy link
Author

colinkho commented May 3, 2024

Amended commit and force pushed to correct username to allow detection of CLA

@tonihei
Copy link
Collaborator

tonihei commented May 14, 2024

Thanks, I'll continue the merge process internally and will probably force-push too with additional formatting updates etc.

@tonihei tonihei force-pushed the set-play-when-ready-load-control-branch branch 3 times, most recently from 718ca05 to c3ee6f6 Compare May 17, 2024 09:44
@tonihei tonihei force-pushed the set-play-when-ready-load-control-branch branch from c3ee6f6 to c46bb24 Compare May 20, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants