Fix wav format pcm encoding detection error #1103
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I exported some long-duration audio files in wav format from Adobe Audition, but there was a harsh noise when played on exoplayer.
Root Cause
WavExtractor#readFormat
ignores GUIDs declared in fmt blocks when making PCM format selections.Only integer bit depths are considered when
TYPE_WAVE_FORMAT_EXTENSIBLE (0xFFFE)
is detected.Solution
Parse
WavFormat.extraData
to get GUID to determine PCM data type, add missingENCODING_PCM_FLOAT
AUDIO_MLAW
AUDIO_ALAW
.Links