Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix - remove width property of bottomSheet modifier #483

Open
wants to merge 1 commit into
base: androidx-main
Choose a base branch
from

Conversation

YunByungKwan
Copy link

@YunByungKwan YunByungKwan commented Jan 30, 2023

Proposed Changes

Short description

I want the fillMaxWidth() property applied to the Surface that constitutes the BottomSheetScaffold's sheetContent to be removed.

Long description

The reason is because I want to always show the width of the sheetContent as the width of the content, not the fillMaxWidth in landscape mode.

Currently, to set the width of the sheetContent to a specific dp value in landscape mode, the width of the BottomSheetScaffold itself must be adjusted.

However, in this case, if the UI of the app shows a map such as Google Map, there is an issue that the touch event is not delivered well.

I guess many apps don't want the width of the bottomSheet to always be full in landscape mode.

The ui layer of our app in landscape mode looks like this: (카카오맵 = Map such as Google Map)

스크린샷 2023-01-31 10 02 11

Testing

Test:
I copied all the BottomSheetScaffold codes and modified only the parts I wanted to test.
The result was successful!
To create the CustomBottomSheetScaffold I also had to copy the Swipeable because of the line of code below.

internal val nestedScrollConnection = this.PreUpPostDownNestedScrollConnection

Issues Fixed

Fixes:

@google-cla
Copy link

google-cla bot commented Jan 30, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant