Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MotionCompose: Update dependencies #90

Merged
merged 2 commits into from Jun 6, 2022
Merged

Conversation

yaraki
Copy link
Member

@yaraki yaraki commented Jun 3, 2022

Migrate from accompanist-insets to the official 'androidx.compose.foundation' insets.
https://google.github.io/accompanist/insets/#migration

Change-Id: I4a1593141c8232d94f2d2c995b03d327daa2669a

Migrate from accompanist-insets to the official 'androidx.compose.foundation' insets.
https://google.github.io/accompanist/insets/#migration

Change-Id: I4a1593141c8232d94f2d2c995b03d327daa2669a
@yaraki yaraki requested a review from riggaroo June 3, 2022 03:08

def accompanist_version = '0.22.0-rc'
def accompanist_version = '0.24.9-beta'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe there is still this release blocking google/accompanist#1186? @bentrengrove do we need to wait for accompanist to upgrade to beta03 of compose?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should match your accompanist version to the compose version so technically yes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It probably will be fine though if you aren't using navigation-material

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v0.24.10-beta is now out

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to v0.24.10-beta.

Change-Id: I21163057190e1c2fd647c2f312d298701c8fc5a7
@yaraki yaraki merged commit 95cd0cc into main Jun 6, 2022
@yaraki yaraki deleted the yaraki/MotionCompose-update branch June 6, 2022 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants