test: Add test for invalid password.

code_style.sh

@@ -2,4 +2,4 @@
 
 set -e
 
-pycodestyle bin/ zyxelprometheus/
+pycodestyle bin/ zyxelprometheus/ tests/

tests/test_login.py

@@ -20,15 +20,30 @@
 
 import responses
 
-from zyxelprometheus import login
+from zyxelprometheus import login, InvalidPassword
+
 
 class TestLogin(unittest.TestCase):
     @responses.activate
     def test_correct_password(self):
-        responses.add(responses.POST, 'https://192.168.1.1/UserLogin', status=200)
+        responses.add(responses.POST, 'https://192.168.1.1/UserLogin',
+                      status=200)
 
         login("https://192.168.1.1", "admin", "testpassword")
-
+
+        self.assertEqual(1, len(responses.calls))
+        data = json.loads(responses.calls[0].request.body)
+        self.assertEqual("admin", data["Input_Account"])
+        self.assertEqual(b"testpassword", b64decode(data["Input_Passwd"]))
+
+    @responses.activate
+    def test_wrong_password(self):
+        responses.add(responses.POST, 'https://192.168.1.1/UserLogin',
+                      status=401)
+
+        with self.assertRaises(InvalidPassword):
+            login("https://192.168.1.1", "admin", "testpassword")
+
         self.assertEqual(1, len(responses.calls))
         data = json.loads(responses.calls[0].request.body)
         self.assertEqual("admin", data["Input_Account"])

zyxelprometheus/__init__.py

@@ -14,6 +14,7 @@
 # You should have received a copy of the GNU General Public License
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
+from .exceptions import InvalidPassword
 from .login import login
 from .prometheus import prometheus
 from .scrape import scrape_xdsl, scrape_traffic

zyxelprometheus/exceptions.py

@@ -0,0 +1,18 @@
+# zyxelprometheus
+# Copyright (C) 2020 Andrew Wilkinson
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+class InvalidPassword(Exception):
+    pass

zyxelprometheus/login.py

@@ -19,6 +19,8 @@
 
 import requests
 
+from .exceptions import InvalidPassword
+
 # https://192.168.1.1/UserLogin
 # {"Input_Account":"admin","Input_Passwd":"c2hhZ2dpZTE:",
 #  "currLang":"en","RememberPassword":0,"SHA512_password":false}
@@ -34,6 +36,8 @@ def login(host, username, password):
         "RememberPassword": 0,
         "SHA512_password": False
     }))
+    if r.status_code == 401:
+        raise InvalidPassword("Invalid username or password.")
     r.raise_for_status()
 
     return session