Skip to content

Commit

Permalink
Fix EtcdServer leak in etcd_server_test.py file (pytorch#125121)
Browse files Browse the repository at this point in the history
As stated in the title.

Pull Request resolved: pytorch#125121
Approved by: https://github.com/Skylion007
  • Loading branch information
cdzhan authored and andoorve committed May 1, 2024
1 parent 9746436 commit d97568c
Showing 1 changed file with 19 additions and 16 deletions.
35 changes: 19 additions & 16 deletions test/distributed/elastic/rendezvous/etcd_server_test.py
Expand Up @@ -41,19 +41,22 @@ def test_etcd_server_with_rendezvous(self):
server = EtcdServer()
server.start()

client = etcd.Client(server.get_host(), server.get_port())

rdzv = EtcdRendezvous(
client=client,
prefix="test",
run_id=1,
num_min_workers=1,
num_max_workers=1,
timeout=60,
last_call_timeout=30,
)
rdzv_handler = EtcdRendezvousHandler(rdzv)
store, rank, world_size = rdzv_handler.next_rendezvous()
self.assertIsNotNone(store)
self.assertEqual(0, rank)
self.assertEqual(1, world_size)
try:
client = etcd.Client(server.get_host(), server.get_port())

rdzv = EtcdRendezvous(
client=client,
prefix="test",
run_id=1,
num_min_workers=1,
num_max_workers=1,
timeout=60,
last_call_timeout=30,
)
rdzv_handler = EtcdRendezvousHandler(rdzv)
store, rank, world_size = rdzv_handler.next_rendezvous()
self.assertIsNotNone(store)
self.assertEqual(0, rank)
self.assertEqual(1, world_size)
finally:
server.stop()

0 comments on commit d97568c

Please sign in to comment.