Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bad parsing of create table statements that use lower case #642

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

mrmasterplan
Copy link
Collaborator

there were missing upper() calls that messed up parsing of some of my create table statements.
Try running the new test without and with my contribution and you will see the bad behavior.

Best,

Simon

@mrmasterplan
Copy link
Collaborator Author

Seems related to issue #217 and #543. Both had issues with lowercase create table statements.

@andialbrecht andialbrecht added this to the 0.4.3 milestone Aug 24, 2022
@andialbrecht andialbrecht merged commit 403de6f into andialbrecht:master Aug 24, 2022
@andialbrecht
Copy link
Owner

wow! That slipped through for so long! Nice catch. Thank you!

@andialbrecht
Copy link
Owner

btw, #543 is a different topic. There the LIKE keyword has a different meaning in a DDL context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants