Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
formats
used by thesyft
package to ensure that no formats panic when trying to decode or validate an empty SBOM.nil
check to the SPDX document processing logic.Additionally, for convenience, I implemented
fmt.Stringer
on theformat.ID
type for use in string descriptions of format operations. This can be undone if needed!This prevents the panic shown in anchore/grype#693, but a separate Grype PR will catch the "empty SBOM" case even earlier to provide a more direct error message to the user. So this PR isn't strictly necessary with regard to anchore/grype#693, but it still fixes a panic case for the Syft library.