Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional PHP metadata #753

Merged
merged 3 commits into from Jan 19, 2022
Merged

Add additional PHP metadata #753

merged 3 commits into from Jan 19, 2022

Conversation

wagoodman
Copy link
Contributor

Adds additional PHP metadata as a follow up to #609 and #643 . This additionally adds better pURL support for composer packages derived from the new metadata (related to anchore/grype#395).

@wagoodman wagoodman added enhancement New feature or request ecosystem:php relating to the php ecosystem labels Jan 18, 2022
@wagoodman wagoodman requested a review from a team January 18, 2022 21:50
@wagoodman wagoodman self-assigned this Jan 18, 2022
@github-actions
Copy link

github-actions bot commented Jan 18, 2022

Benchmark Test Results

Benchmark results from the latest changes vs base branch
name                                                       old time/op    new time/op    delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2              1.69ms ± 3%    1.42ms ± 6%  -16.20%  (p=0.008 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2            3.90ms ±10%    3.18ms ± 3%  -18.51%  (p=0.008 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2    1.18ms ± 1%    1.11ms ± 1%   -6.34%  (p=0.008 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2        1.04ms ± 2%    0.87ms ± 4%  -16.44%  (p=0.008 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                    1.20ms ± 1%    1.00ms ± 2%  -16.54%  (p=0.008 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                     1.11ms ± 2%    0.89ms ± 1%  -20.03%  (p=0.008 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      17.7ms ± 2%    14.2ms ± 1%  -19.52%  (p=0.008 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.61ms ± 2%    1.31ms ± 1%  -18.64%  (p=0.008 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2          2.36µs ± 3%    2.06µs ± 5%  -12.50%  (p=0.008 n=5+5)

name                                                       old alloc/op   new alloc/op   delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2               253kB ± 0%     252kB ± 0%     ~     (p=0.310 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2            1.06MB ± 0%    1.06MB ± 0%     ~     (p=0.421 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     230kB ± 0%     253kB ± 0%   +9.99%  (p=0.008 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         207kB ± 0%     207kB ± 0%     ~     (p=0.095 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                     253kB ± 0%     253kB ± 0%     ~     (p=0.056 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                      235kB ± 0%     235kB ± 0%     ~     (p=0.056 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      3.78MB ± 0%    3.78MB ± 0%     ~     (p=0.151 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.30MB ± 0%    1.30MB ± 0%   -0.04%  (p=0.008 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2            560B ± 0%      560B ± 0%     ~     (all equal)

name                                                       old allocs/op  new allocs/op  delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2               6.33k ± 0%     6.33k ± 0%     ~     (all equal)
ImagePackageCatalogers/python-package-cataloger-2             21.4k ± 0%     21.4k ± 0%     ~     (p=0.238 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     6.06k ± 0%     7.26k ± 0%  +19.74%  (p=0.008 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         5.34k ± 0%     5.34k ± 0%     ~     (all equal)
ImagePackageCatalogers/dpkgdb-cataloger-2                     7.07k ± 0%     7.07k ± 0%     ~     (all equal)
ImagePackageCatalogers/rpmdb-cataloger-2                      6.80k ± 0%     6.80k ± 0%     ~     (all equal)
ImagePackageCatalogers/java-cataloger-2                       74.7k ± 0%     74.7k ± 0%     ~     (p=0.381 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                      7.36k ± 0%     7.36k ± 0%     ~     (p=0.167 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2            13.0 ± 0%      13.0 ± 0%     ~     (all equal)

Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
@wagoodman wagoodman merged commit 829e500 into main Jan 19, 2022
@wagoodman wagoodman deleted the add-php-metadata branch January 19, 2022 16:42
spiffcs added a commit that referenced this pull request Jan 19, 2022
…hub.com/hectorj2f/syft into hectorj2f/add_dependencies_to_cyclonedx

* 'hectorj2f/add_dependencies_to_cyclonedx' of https://github.com/hectorj2f/syft: (29 commits)
  Improve CycloneDX format output (#710)
  Add additional PHP metadata (#753)
  Update Syft formats for SyftJson (#752)
  Add support for "file" source type in syftjson unmarshaling (#750)
  remove contains file from spdx dependency generation
  support .sar for java ecosystem (#748)
  Start developer documentation (#746)
  Align SPDX export more with SPDX 2.2 specification (#743)
  Replace distro type (#742)
  update goreleaser with windows checksums (#740)
  bump stereoscope version to remove old containerd (#741)
  Add support for multiple output files in different formats (#732)
  Add support for searching for jars within archives (#734)
  683 windows filepath (#735)
  Fix CPE encode/decode when it contains special chars (#714)
  support .par for java ecosystems (#727)
  Add arm64 support to install script (#729)
  Revert "bump goreleaser to v1.2 (#720)" (#731)
  Add a version flag (#722)
  Add lpkg as java package format (#694)
  ...
fengshunli pushed a commit to fengshunli/syft that referenced this pull request Jan 24, 2022
* add php related metadata

Signed-off-by: Alex Goodman <alex.goodman@anchore.com>

* enable decoding of php metadata for syftjson format

Signed-off-by: Alex Goodman <alex.goodman@anchore.com>

* add php metadata to json schema

Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
Signed-off-by: fsl <1171313930@qq.com>
spiffcs pushed a commit that referenced this pull request Jan 24, 2022
* add php related metadata

Signed-off-by: Alex Goodman <alex.goodman@anchore.com>

* enable decoding of php metadata for syftjson format

Signed-off-by: Alex Goodman <alex.goodman@anchore.com>

* add php metadata to json schema

Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
spiffcs pushed a commit that referenced this pull request Jan 25, 2022
* add php related metadata

Signed-off-by: Alex Goodman <alex.goodman@anchore.com>

* enable decoding of php metadata for syftjson format

Signed-off-by: Alex Goodman <alex.goodman@anchore.com>

* add php metadata to json schema

Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
jonasagx pushed a commit to jonasagx/syft that referenced this pull request Jan 28, 2022
* add php related metadata

Signed-off-by: Alex Goodman <alex.goodman@anchore.com>

* enable decoding of php metadata for syftjson format

Signed-off-by: Alex Goodman <alex.goodman@anchore.com>

* add php metadata to json schema

Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
* add php related metadata

Signed-off-by: Alex Goodman <alex.goodman@anchore.com>

* enable decoding of php metadata for syftjson format

Signed-off-by: Alex Goodman <alex.goodman@anchore.com>

* add php metadata to json schema

Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ecosystem:php relating to the php ecosystem enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants