Improve SPDX decoding functionality #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Benchmark Test ResultsBenchmark results from the latest changes vs base branch |
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
wagoodman
reviewed
Feb 1, 2022
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
jonasagx
reviewed
Feb 7, 2022
jonasagx
reviewed
Feb 7, 2022
jonasagx
reviewed
Feb 7, 2022
jonasagx
reviewed
Feb 8, 2022
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
wagoodman
reviewed
Feb 9, 2022
| s := &sbom.SBOM{ | ||
| Artifacts: sbom.Artifacts{ | ||
| PackageCatalog: pkg.NewCatalog(), | ||
| FileMetadata: map[source.Coordinates]source.FileMetadata{}, |
There was a problem hiding this comment.
nit: idiomatic go comment
Suggested change
| FileMetadata: map[source.Coordinates]source.FileMetadata{}, | |
| FileMetadata: make(map[source.Coordinates]source.FileMetadata), |
There was a problem hiding this comment.
ok, will remember this and follow on a fix later :)
wagoodman
reviewed
Feb 9, 2022
| for _, typ := range f.FileType { | ||
| switch FileType(typ) { | ||
| case ImageFileType: | ||
| meta.MIMEType = "image/" |
There was a problem hiding this comment.
question: is is valid to have partial mimetypes like this?
There was a problem hiding this comment.
not really, but we don't have any additional info, this was the lossiness I was referring to
wagoodman
approved these changes
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to ingest SPDX JSON and Tag-Value formats and convert them to internal Syft data model.
This will be the basis for: anchore/grype#395
Note: there is a branch with a quick hack of SBOM input for Syft