Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SBOM data structure in ImportConfig #621

Merged
merged 1 commit into from
Nov 8, 2021
Merged

Conversation

wagoodman
Copy link
Contributor

Migrates the import code to use the new sbom.SBOM data structure.

This is a follow up from a PR comment here: #606 (comment)

Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
@wagoodman wagoodman requested a review from a team November 8, 2021 20:42
@wagoodman wagoodman self-assigned this Nov 8, 2021
@wagoodman wagoodman changed the title use sbom.SBOM in ImportConfig Use SBOM data structure in ImportConfig Nov 8, 2021
@github-actions
Copy link

github-actions bot commented Nov 8, 2021

Benchmark Test Results

Benchmark results from the latest changes vs base branch
name                                                   old time/op    new time/op    delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2          1.27ms ± 0%    1.27ms ± 1%    ~     (p=0.905 n=4+5)
ImagePackageCatalogers/python-package-cataloger-2        2.90ms ± 1%    2.94ms ± 1%    ~     (p=0.056 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2     755µs ± 2%     750µs ± 0%    ~     (p=0.421 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                 824µs ± 0%     821µs ± 0%  -0.38%  (p=0.032 n=5+4)
ImagePackageCatalogers/rpmdb-cataloger-2                  779µs ± 0%     784µs ± 1%  +0.59%  (p=0.008 n=5+5)
ImagePackageCatalogers/java-cataloger-2                  10.9ms ± 1%    10.9ms ± 1%    ~     (p=0.548 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                 1.15ms ± 0%    1.15ms ± 0%  -0.51%  (p=0.032 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2       617ns ± 1%     621ns ± 1%    ~     (p=0.095 n=5+5)

name                                                   old alloc/op   new alloc/op   delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2           247kB ± 0%     247kB ± 0%    ~     (p=1.000 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2        1.10MB ± 0%    1.10MB ± 0%    ~     (p=0.310 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2     197kB ± 0%     197kB ± 0%    ~     (p=0.095 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                 228kB ± 0%     228kB ± 0%  -0.06%  (p=0.008 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                  221kB ± 0%     221kB ± 0%    ~     (p=1.000 n=5+5)
ImagePackageCatalogers/java-cataloger-2                  3.24MB ± 0%    3.24MB ± 0%    ~     (p=0.095 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                 1.29MB ± 0%    1.29MB ± 0%    ~     (p=0.548 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2        336B ± 0%      336B ± 0%    ~     (all equal)

name                                                   old allocs/op  new allocs/op  delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2           6.79k ± 0%     6.79k ± 0%    ~     (all equal)
ImagePackageCatalogers/python-package-cataloger-2         26.3k ± 0%     26.3k ± 0%    ~     (p=0.690 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2     5.17k ± 0%     5.17k ± 0%    ~     (all equal)
ImagePackageCatalogers/dpkgdb-cataloger-2                 6.65k ± 0%     6.65k ± 0%    ~     (all equal)
ImagePackageCatalogers/rpmdb-cataloger-2                  6.53k ± 0%     6.53k ± 0%    ~     (all equal)
ImagePackageCatalogers/java-cataloger-2                   58.9k ± 0%     58.9k ± 0%    ~     (p=0.405 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                  7.71k ± 0%     7.71k ± 0%    ~     (p=0.683 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2        9.00 ± 0%      9.00 ± 0%    ~     (all equal)

@wagoodman wagoodman merged commit 9c27fa7 into main Nov 8, 2021
@wagoodman wagoodman deleted the sbom-doc-for-import branch November 8, 2021 23:39
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants