Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure progress tracker completes execution #100

Merged
merged 4 commits into from Feb 9, 2022
Merged

ensure progress tracker completes execution #100

merged 4 commits into from Feb 9, 2022

Conversation

jonasagx
Copy link
Contributor

@jonasagx jonasagx commented Feb 4, 2022 •
edited

Fixes #764
Signed-off-by: Jonas Galvão Xavier jonas.agx@gmail.com

@jonasagx
ensure progress tracker completes execution
50f3156 
Signed-off-by: Jonas Galvão Xavier <jonas.agx@gmail.com>
@jonasagx jonasagx marked this pull request as draft February 4, 2022 23:44
@jonasagx
expand comment on daemon provider's progress
cf39e0e 
Signed-off-by: Jonas Galvão Xavier <jonas.agx@gmail.com>
@jonasagx jonasagx marked this pull request as ready for review February 7, 2022 22:21
@jonasagx jonasagx requested a review from a team February 8, 2022 17:05
kzantow
kzantow approved these changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@kzantow kzantow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems good to me, not being especially familiar with why the copyProgress.SetComplete() wasn't being called before

pkg/image/docker/daemon_provider.go Outdated Show resolved Hide resolved
@jonasagx
feedback changes
860bc8b 
Signed-off-by: Jonas Galvão Xavier <jonas.agx@gmail.com>
@jonasagx
make static-analysis happy
9be890c 
Signed-off-by: Jonas Galvão Xavier <jonas.agx@gmail.com>
@jonasagx jonasagx merged commit 3e49686 into anchore:main Feb 9, 2022
@jonasagx jonasagx mentioned this pull request Feb 9, 2022
Merged
@jonasagx jonasagx self-assigned this Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wagoodman wagoodman wagoodman left review comments

@kzantow kzantow kzantow approved these changes

Assignees

@jonasagx jonasagx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Syft stuck on some images (also affecting grype)
3 participants
@jonasagx @wagoodman @kzantow