Halt execution when invalid options are provided #76
Conversation
Signed-off-by: Alfredo Deza <adeza@anchore.com>
alfredodeza
force-pushed
the
issue-74
branch
2 times, most recently
from
9724466
to
3d88dea
Compare
Signed-off-by: Alfredo Deza <adeza@anchore.com>
Signed-off-by: Alfredo Deza <adeza@anchore.com>
Signed-off-by: Alfredo Deza <adeza@anchore.com>
Signed-off-by: Alfredo Deza <adeza@anchore.com>
| JOB=$1 | ||
|
|
||
| # ensure this is at the root | ||
| cd "$SCRIPTPATH/.." |
There was a problem hiding this comment.
nit / clarifying question: if this script is only meant to run in the root of the repo, would $(pwd) be alright instead?
There was a problem hiding this comment.
interesting, yes, I think that would work. I did it this way to ensure that regardless of where it runs it is always correct. Do you think that assurance is overkill?
| core.setFailed( | ||
| "At least one source for scanning needs to be provided. Available options are: image, and path" | ||
| ); | ||
| throw new Error("At least one source for scanning needs to be provided. Available options are: image, and path"); |
There was a problem hiding this comment.
(no change needed) I took another look at this (re our Zoom chat the other day) and it makes sense why this was needed. Throwing an error accomplishes failing the job and skipping the remainder code, only because of the try/catch setup here. Another option is to control the flow via an early return, which lets you control the execution separately from deciding the job status if you ever need to. That might be of interest if we want to move away from large try blocks one day 😃
There was a problem hiding this comment.
That is a good point. I will open a ticket to track this improvement
Closes #67
actmake checkwhich in turn runs all the new test harness