Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove usage of 'core.addPath' #72

Merged
merged 1 commit into from Nov 10, 2020
Merged

remove usage of 'core.addPath' #72

merged 1 commit into from Nov 10, 2020

Conversation

alfredodeza
Copy link
Contributor

The usage of core.addPath was causing the creation of add-path into the dist/index.js binary via ncc. By removing core.addPath there are no more warnings. The path is now used directly via the cache instead of just grype.

Closes #71

@alfredodeza
Copy link
Contributor Author

@jonico I believe this one fixes the problem. Mind double checking the changes? I don't see the warnings anymore

@jonico
Copy link
Contributor

jonico commented Nov 5, 2020

@alfredodeza: While the code changes look ok to me, you could also just upgrade actions/core to 1.2.6: actions/toolkit#582

@alfredodeza
Copy link
Contributor Author

@jonico thanks for the suggestion. The package.json file already declares actions/core at ^1.2.6, do you mean some other version? Any pointers would be great, because I do think that bumping that is a good idea as well!

@jonico
Copy link
Contributor

jonico commented Nov 6, 2020

@alfredodeza: weird, your package.json indicates that should already be at the right version of the package and still core.add-path uses the old syntax

Looking into the source of core.add-path

... could it be that for some reason the env GITHUB_PATH is not set properly in your action?

Signed-off-by: Alfredo Deza <adeza@anchore.com>
@alfredodeza
Copy link
Contributor Author

@jonico I've updated actions/core locally and now the build properly shows the 1.2.6 version. Thanks for catching up. Would love a second look at the changes if you don't mind :) (I dropped the action changes now that 1.2.6 is being used)

@jonico
Copy link
Contributor

jonico commented Nov 10, 2020

🚢 it!

Copy link
Contributor

@jonico jonico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@alfredodeza alfredodeza merged commit 2008992 into main Nov 10, 2020
@alfredodeza alfredodeza deleted the issue-71 branch November 10, 2020 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not use deprecated add-path command
2 participants