-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Add input grype-version #228
[feature] Add input grype-version #228
Conversation
8a129d7
to
7319da8
Compare
Could be test of input has to be moved to some "demo" workflow, not sure about this moment. |
Hi @kzantow |
Hello, |
Signed-off-by: Viacheslav Kudinov <viacheslav@kudinov.tech> Signed-off-by: Viacheslav Kudinov <viacheslavkudinov@VK-MacBook-Pro-14-M1.local>
Signed-off-by: Viacheslav Kudinov <viacheslav@kudinov.tech> Signed-off-by: Viacheslav Kudinov <viacheslavkudinov@VK-MacBook-Pro-14-M1.local>
Signed-off-by: Viacheslav Kudinov <viacheslav@kudinov.tech> Signed-off-by: Viacheslav Kudinov <viacheslavkudinov@VK-MacBook-Pro-14-M1.local>
Signed-off-by: Viacheslav Kudinov <viacheslav@kudinov.tech> Signed-off-by: Viacheslav Kudinov <viacheslavkudinov@VK-MacBook-Pro-14-M1.local>
Signed-off-by: Viacheslav Kudinov <viacheslav@kudinov.tech> Signed-off-by: Viacheslav Kudinov <viacheslavkudinov@VK-MacBook-Pro-14-M1.local>
Signed-off-by: Viacheslav Kudinov <viacheslav@kudinov.tech> Signed-off-by: Viacheslav Kudinov <viacheslavkudinov@VK-MacBook-Pro-14-M1.local>
Signed-off-by: Viacheslav Kudinov <viacheslav@kudinov.tech> Signed-off-by: Viacheslav Kudinov <viacheslavkudinov@VK-MacBook-Pro-14-M1.local>
Signed-off-by: Viacheslav Kudinov <viacheslav@kudinov.tech> Signed-off-by: Viacheslav Kudinov <viacheslavkudinov@VK-MacBook-Pro-14-M1.local>
Signed-off-by: GitHub <noreply@github.com> Co-authored-by: willmurphyscode <willmurphyscode@users.noreply.github.com> Signed-off-by: Viacheslav Kudinov <viacheslavkudinov@VK-MacBook-Pro-14-M1.local>
Signed-off-by: Viacheslav Kudinov <viacheslavkudinov@VK-MacBook-Pro-14-M1.local>
Signed-off-by: Viacheslav Kudinov <viacheslav@kudinov.tech>
Signed-off-by: Viacheslav Kudinov <viacheslav@kudinov.tech>
Signed-off-by: Viacheslav Kudinov <viacheslav@kudinov.tech>
Signed-off-by: Viacheslav Kudinov <viacheslav@kudinov.tech>
79ac295
to
f0a9f17
Compare
Signed-off-by: Viacheslav Kudinov <viacheslav@kudinov.tech>
Signed-off-by: Viacheslav Kudinov <viacheslav@kudinov.tech>
Signed-off-by: Viacheslav Kudinov <viacheslav@kudinov.tech>
Signed-off-by: Viacheslav Kudinov <viacheslav@kudinov.tech>
Signed-off-by: Viacheslav Kudinov <viacheslav@kudinov.tech>
Signed-off-by: Viacheslav Kudinov <viacheslav@kudinov.tech>
Signed-off-by: Viacheslav Kudinov <viacheslav@kudinov.tech>
Hi @willmurphyscode |
or @wagoodman ? |
Thanks much for the contribution, and sorry for the delay. I'm trying to get a release out today that will update to latest grype, and then have a couple additional chores to do in the repo. After that I'll get the changes from main into this branch and then try to get it reviewed and merged. |
Hi @willmurphyscode |
@willmurphyscode related question. |
@ViacheslavKudinov good question! We removed snapshot testing for a few reasons:
|
@ViacheslavKudinov thanks for offering to get your changes rebased on the new release! I also plan to upgrade an pin some actions today. If you wouldn't mind waiting until #250 is in, that would probably save you rebasing / merging |
I will merge GH Actions changes into my branch as well. |
Signed-off-by: Viacheslav Kudinov <viacheslav@kudinov.tech>
e35de46
to
528c5f3
Compare
Thanks @ViacheslavKudinov! We'll get this out in the next release. |
Thank you @willmurphyscode |
grype-version
input to have ability to set specific version of Grype.debug
input related things (input doesn't exist on the current version of JS code but adds extra annotation on Action tab: