Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade tool management #1842

Merged
merged 2 commits into from May 9, 2024
Merged

Upgrade tool management #1842

merged 2 commits into from May 9, 2024

Conversation

wagoodman
Copy link
Contributor

This PR brings grype in line with the upgrades done in other repos by:

  • Upgrades the Makefile to a Taskfile. A much smaller Makefile has been left behind for convenience, easy bootstrapping in CI, and for those of use that can't shake the muscle memory of typing make ... (slowly raises hand).
  • Uses binny to manage tools to utilize a caching strategy and improve quality of life while developing. This still keeps all tooling that is used in the repo in a local directory, however, that directory is now .tool instead of .tmp.

Closes #1773

@wagoodman wagoodman force-pushed the upgrade-tool-management branch 3 times, most recently from 869a147 to 9baf04c Compare May 6, 2024 19:41
@wagoodman wagoodman requested a review from a team May 6, 2024 19:42
@wagoodman wagoodman marked this pull request as ready for review May 6, 2024 19:42
@wagoodman wagoodman added the changelog-ignore Don't include this issue in the release changelog label May 6, 2024
@wagoodman wagoodman self-assigned this May 6, 2024
kzantow
kzantow approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@kzantow kzantow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

.github/scripts/update-version-file.sh Show resolved Hide resolved
@wagoodman
upgrade tool management
aba4d04 
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
@wagoodman
update version file on release
7fd7a20 
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
@wagoodman wagoodman enabled auto-merge (squash) May 9, 2024 18:21
@wagoodman wagoodman disabled auto-merge May 9, 2024 18:39
@wagoodman wagoodman merged commit 24d5d4f into main May 9, 2024
10 checks passed
@wagoodman wagoodman deleted the upgrade-tool-management branch May 9, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kzantow kzantow kzantow approved these changes

Assignees

@wagoodman wagoodman

Labels
changelog-ignore Don't include this issue in the release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make bootstrap fails on clean pull of main
2 participants
@wagoodman @kzantow