Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update sarif to pass microsoft validator #1838

Merged
merged 1 commit into from Apr 30, 2024
Merged

Conversation

kzantow
Copy link
Contributor

@kzantow kzantow commented Apr 30, 2024

This PR adjusts the SARIF output to pass the Microsoft JS validator and adds a validation step to the unit tests.

Fixes: #1833
Fixes: #1518

Signed-off-by: Keith Zantow <kzantow@gmail.com>
@spiffcs spiffcs merged commit 6b9ea21 into main Apr 30, 2024
10 checks passed
@spiffcs spiffcs deleted the fix/valid-sarif-output branch April 30, 2024 18:45
@kzantow kzantow added bug Something isn't working and removed bug Something isn't working labels May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add SARIF validation to test suite SARIF output not compatible with GitHub
2 participants