Feat/allow configuring timeout for external sources #1812
Conversation
| maven: | ||
| search-upstream-by-sha1: true |
There was a problem hiding this comment.
👋 thanks for adding the new field! Would it be possible to keep the field name here so that we don't release a breaking change? I know we're pre v1.0, but the best way to handle this is to deprecate this field and add the new one (allowing people to migrate) rather than changing it on the fly =)
There was a problem hiding this comment.
Oh wow - on second pass it looks like the json/yaml tags here were never correct here so thanks for the catch and docs update. I've made a note to change the json tag to be consistent going forward.
|
@pouyan021 Approved and running checks now - Thank you so much for the contribution! |
|
@pouyan021 looks like there is a small change needed where |
pouyan021
force-pushed
the
feat/allow-configuring-timeout-for-external-sources
branch
from
c7f9e41
to
5cc6f4b
Compare
Signed-off-by: Pouyan Khodabakhsh <pouyan021@gmail.com>
Signed-off-by: Pouyan Khodabakhsh <pouyan021@gmail.com>
Signed-off-by: Pouyan Khodabakhsh <pouyan021@gmail.com>
… functionality Signed-off-by: Pouyan Khodabakhsh <pouyan021@gmail.com>
…-after functionality Signed-off-by: Pouyan Khodabakhsh <pouyan021@gmail.com>
Signed-off-by: Pouyan Khodabakhsh <pouyan021@gmail.com>
Signed-off-by: Pouyan Khodabakhsh <pouyan021@gmail.com>
Signed-off-by: Pouyan Khodabakhsh <pouyan021@gmail.com>
pouyan021
force-pushed
the
feat/allow-configuring-timeout-for-external-sources
branch
from
5cc6f4b
to
e5ed88d
Compare
|
@spiffcs Appreciate your support, thanks a lot! The problem with go.mod is addressed but I forgot to sign-off my commit! I fixed that and pushed again. Could you kindly approve the checks once more? |
There was a problem hiding this comment.
Everything else LGTM - Just waiting for @wagoodman and his final say on the config direction he wants to go here
| base-url: https://search.maven.org/solrsearch/select | ||
| abort-after: 5m #override the global config |
There was a problem hiding this comment.
cc @wagoodman - I know he's pretty sensitive to duplicate fields that override each other so I'd like him to chime in on where he sees this going or what his preference would be
This pull request closes #1624. It adds and enforces the ability to set a new property
abort-aftertoexternalsources. As discussed in the issue, it supports both a global prop and amavenproperty that overrides the global if it is set.