Should only use hermetic sprig functions in templates #1288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wagoodman
added
the
changelog-ignore
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
wagoodman
force-pushed
the
must-use-hermetic-fn
branch
from
b7a7a14
to
c21ff69
Compare
willmurphyscode
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This functionally reverts #1273 (issue #1243). The reasons for this is to ensure a user does not unintentionally leak sensitive information through a rendered template (some discussion from the original PR #610 ). #1243 is generically looking for full sprig function support, and though this may be useful in certain cases, we believe that grype should remain as safe as possible to run in any environment. We recommend to only use templates that are crafted by a trusted user but we can't enumerate all of the usages of grype in the wild, so it may be possible that someone could be supplying user-controlled templates into grype --we want grype to still be as secure as possible in those circumstances.