Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SARIF validation to test suite #1833

Closed
kzantow opened this issue Apr 26, 2024 · 0 comments · Fixed by #1838
Closed

Add SARIF validation to test suite #1833

kzantow opened this issue Apr 26, 2024 · 0 comments · Fixed by #1838
Assignees
Labels
changelog-ignore Don't include this issue in the release changelog enhancement New feature or request

Comments

@kzantow
Copy link
Contributor

kzantow commented Apr 26, 2024

What would you like to be added:
SAIRF output validation tests.

Why is this needed:
One of the output formats Grype supports is SARIF. Today, we are not validating that the SARIF files Grype creates are valid. One way to are able to validate them is using the NPM package @microsoft/jest-sarif. We would probably be able to make a container that can be passed a SARIF file and it validates in order to incorporate this functionality into the Grype test suite (other suggestions welcome!).

Additional context:
We are validating SARIF in the scan-action using the aforementioned library (see here).

@kzantow kzantow added enhancement New feature or request changelog-ignore Don't include this issue in the release changelog labels Apr 26, 2024
@kzantow kzantow self-assigned this Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-ignore Don't include this issue in the release changelog enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant