generated from anagudelogu/ruby-rubocop-template
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decorate a class #2
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
ec07700
Create Nameable class
anagudelogu eb536c8
Create BaseDecorator class
anagudelogu 9cde468
Create CapitalizeDecorator class
anagudelogu f1f114f
Create TrimmerDecorator class
anagudelogu 6dcb97f
Make person class nameable and create a correct_name method
anagudelogu fbd949f
Remove unnecesary imports
anagudelogu File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
require_relative './nameable' | ||
|
||
class BaseDecorator < Nameable | ||
attr_accessor :nameable | ||
|
||
def initialize(nameable) | ||
super() | ||
@nameable = nameable | ||
end | ||
|
||
def correct_name | ||
@nameable.correct_name | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
require_relative './base_decorator' | ||
|
||
class CapitalizeDecorator < BaseDecorator | ||
def correct_name | ||
@nameable.correct_name.capitalize | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
class Nameable | ||
def correct_name | ||
raise NotImplementedError, "#{self.class} has not implemented method '#{__method__}'" | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,11 @@ | ||
class Person | ||
require_relative './nameable' | ||
|
||
class Person < Nameable | ||
attr_reader :id | ||
attr_accessor :name, :age | ||
|
||
def initialize(age, name = 'Unknown', parent_permission: true) | ||
super() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
@id = Random.rand(1..1000) | ||
@name = name | ||
@age = age | ||
|
@@ -24,4 +27,8 @@ def can_use_service? | |
|
||
false | ||
end | ||
|
||
def correct_name | ||
@name | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
require_relative './base_decorator' | ||
|
||
class TrimmerDecorator < BaseDecorator | ||
def correct_name | ||
name = @nameable.correct_name | ||
size = name.size | ||
return name.slice!(0..9) if size > 10 | ||
|
||
name | ||
end | ||
end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
super
method here because theNameable
class doesn't have an initialize method (constructor). 馃憤There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Gambit142! thank you for your review, I had to add
super
because it throws an offense in rubocop if not added.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @anagudelogu, It is alright, I forgot there has been a debate on this issue since the year 2020. 馃槃 You can get the full story here