♻️🚀 Remove side-effect bloat from amp-story bundle

[alanorozco]

By importing AMP_STORY_PLAYER_EVENT (whose value equals its name), we're accidentally bundling all of @ampproject/toolbox-cache-url. It's equivalent to 2.30 kb compressed (!!!)

Closure knew how to remove this code, but esbuild does not. We move the string to a standalone file.

[amp-owners-bot]

Hey @gmajoulet, @newmuis! These files were changed:

extensions/amp-story/1.0/amp-story-system-layer.js

[samouri]

I had already investigated this and believe I solved it via #37052... did I mess something up there? A separate possibility would be to directly import the module build from node_modules instead of relying on automatic package detection

[alanorozco]

(discussed offline):

@samouri I had already investigated this and believe I solved it via #37052... did I mess something up there?

Your change to use module was correct. But it allows part of the import to be tree-shaken, not its entirety.

[samouri]

Thank you for finding this. You deserve a 🎖️

[gmajoulet]

Thank you Alan! If you ever do a presentation on the tools/process you use to find all of these, that'd be really awesome and useful for a lot of us!