minification: assume pure getters #37054
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jridgewell
approved these changes
Nov 24, 2021
jridgewell
reviewed
Nov 24, 2021
| @@ -570,6 +570,7 @@ async function minify(code, map) { | |||
| // Settled on this count by incrementing number until there was no more | |||
| // effect on minification quality. | |||
| passes: 3, | |||
| 'pure_getters': true, | |||
There was a problem hiding this comment.
This is a bit safer, and will keep things known to throw an error.
Suggested change
| 'pure_getters': true, | |
| 'pure_getters': 'strict', |
There was a problem hiding this comment.
Thats actually the default value.
Maybe this is also resolvable within terser, as I'd expect something like Object.prototype.hasOwnProperty to be "known" not to throw, whereas currently it isn't DCEd
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
summary
Partial for #36453
Assume all of our getters are pure in both our babel transforms and terser minification.