-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🏗🚮 Clean up amphtml
root-level dependencies
#33115
Conversation
@jridgewell @samouri The babel plugin tests are failing while loading a non-existent plugin |
Babel just added this requirement to tests: babel/babel#12911. We'd need to update our |
I opened babel/babel#12982 to make |
Thanks for the fix! In the meantime, instead of editing 100+ Edit: Fix merged with #33145, temporary resolution removed. |
PR highlights:
dependencies
:open
: This should have been indevDependencies
prop-types
: Now installed on-demand bythird_party/react-dates/
(not imported by runtime)devDependencies
:0x
: Not used, cleaned upderequire
: Now installed on-demand bythird_party/react-dates/
envify
: Now installed on-demand bythird_party/react-dates/
pretty-bytes
: Not used, cleaned upreact-addons-shallow-compare
: Now installed on-demand bythird_party/react-dates/
react-externs
: Now installed on-demand bythird_party/react-dates/
react-with-direction
: Now installed on-demand bythird_party/react-dates/
renovate
: Replaced by a direct call tonpx
(this gets updated almost daily and shouldn't have been installed)uglifyify
: Now installed on-demand bythird_party/react-dates/
vinyl-sourcemaps-apply
: Not used, cleaned upwatchify
: Not used, cleaned updevDependencies
:events
: Used but missingopen
: Moved fromdependencies
@babel/plugin-transform-classes
: Used but missingThis results in a 33% reduction in
node_modules
size (~750 MB → ~500 MB) andnpm ci
duration (~30s → ~20s).