🐛 Delayed force-exit gulp test after Karma reports test completion
#14814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/to @cvializ @jridgewell |
rsimha
changed the title
gulp test after Karma reports test completion
|
Tested this locally, and I can verify that |
cramforce
approved these changes
Apr 23, 2018
build-system/tasks/runtime-test.js
Outdated
| @@ -371,7 +371,10 @@ function runTests() { | |||
| log( | |||
| red('ERROR:'), | |||
| yellow('Karma test failed with exit code ' + exitCode)); | |||
| process.exitCode = exitCode; | |||
| // TODO(rsimha): Remove this after Karma / Sauce ticket is resolved. | |||
There was a problem hiding this comment.
Should probably link to issues here.
This was referenced Apr 24, 2018
victorb
pushed a commit
to ipfs/aegir
that referenced
this pull request
May 4, 2018
Karma has some issues letting go after the test run. Ref karma-runner/karma#1788 and ampproject/amphtml#14814 This fix basically forces aegir to close after the karma tests have been successfully run, so instead of a test-run taking 13 seconds for the tests to run then 30 seconds for karma to force-close, it finishes in 14 seconds. Solves #212
This was referenced Sep 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several potential causes for the disconnect / timeout issues we're seeing on Travis, where Karma reports that all tests are complete, but
gulp testdoesn't terminate because something is holding it up from doing so.For example, see https://travis-ci.org/ampproject/amphtml/jobs/370168309
Related issues:
We have a ticket open with Sauce labs to investigate this.
Meanwhile, this PR temporarily mitigates the problem by force-exiting the
gulp testprocess after a gap of 5 seconds, so that Karma reporters can print all their output to the console.Partial fix for #14800