Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gutenberg packages after v12.5.4 release #6910

Merged
merged 5 commits into from Feb 14, 2022

Conversation

westonruter
Copy link
Member

No description provided.

@westonruter westonruter added the dependencies Pull requests that update a dependency file label Feb 11, 2022
@westonruter westonruter added this to the v2.2.2 milestone Feb 11, 2022
@delawski
Copy link
Collaborator

The build:dev and build:prod tasks are failing with the following error:

No entry files discovered in the "src" folder.

It turns out, WordPress/gutenberg#38584 changed the way @wordpress/scripts react to no entry points being present. So far, an empty object {} was returned in such case. Now, an error is returned and the build process exits (see: WordPress/gutenberg#38584 (comment)).

There are some workarounds, e.g. passing an additional env parameter:

- "build:dev": "cross-env NODE_ENV=development npm-run-all 'build:!(dev|prod)'",
+ "build:dev": "cross-env NODE_ENV=development WP_ENTRY={} npm-run-all 'build:!(dev|prod)'",

However, a hotfix has just been issued, too: WordPress/gutenberg#38737

I think we should wait until the hotfix merged and published to npm. After that, we could return to this PR.

pierlon and others added 3 commits February 12, 2022 00:01
…tenberg-v12.5.4-packages

* 'develop' of github.com:ampproject/amp-wp:
  Fix pattern match for package-lock.json
  Ensure non-zero CSS_FILE_COUNT when npm package updated for sake of stylelint
  Bump eslint from 8.8.0 to 8.9.0
  Bump follow-redirects from 1.14.7 to 1.14.8
  Bump eslint-plugin-jsdoc from 37.8.2 to 37.9.0
@github-actions
Copy link
Contributor

github-actions bot commented Feb 14, 2022

Plugin builds for d3026b3 are ready 🛎️!

@westonruter westonruter merged commit 7d0ca30 into develop Feb 14, 2022
@westonruter westonruter deleted the update/gutenberg-v12.5.4-packages branch February 14, 2022 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants