Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update autoprefixer-rails to version that is compatible with execjs 2.8.1 #796

Merged
merged 1 commit into from Jun 3, 2021

Conversation

anaulin
Copy link
Contributor

@anaulin anaulin commented Jun 3, 2021

This should fix the issue with asset precompilation we are seeing on deploys, which manifests as the following traceback upon calling rake assets:precompile:

rake aborted!
ExecJS::ProgramError: TypeError: Cannot read property 'version' of undefined
eval (eval at <anonymous> ((execjs):1:213), <anonymous>:1:10)
(execjs):1:213
(execjs):19:14
(execjs):1:40
Object.<anonymous> ((execjs):1:58)
Module._compile (internal/modules/cjs/loader.js:1063:30)
Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10)
Module.load (internal/modules/cjs/loader.js:928:32)
Function.Module._load (internal/modules/cjs/loader.js:769:14)
Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:72:12)
/Users/anaulin/.gem/ruby/2.7.2/gems/execjs-2.8.1/lib/execjs/external_runtime.rb:39:in `exec'
/Users/anaulin/.gem/ruby/2.7.2/gems/execjs-2.8.1/lib/execjs/external_runtime.rb:21:in `eval'
/Users/anaulin/.gem/ruby/2.7.2/gems/execjs-2.8.1/lib/execjs/runtime.rb:64:in `eval'
/Users/anaulin/.gem/ruby/2.7.2/gems/autoprefixer-rails-9.5.1/lib/autoprefixer-rails/processor.rb:153:in `runtime'
/Users/anaulin/.gem/ruby/2.7.2/gems/autoprefixer-rails-9.5.1/lib/autoprefixer-rails/processor.rb:36:in `process'
/Users/anaulin/.gem/ruby/2.7.2/gems/autoprefixer-rails-9.5.1/lib/autoprefixer-rails/sprockets.rb:20:in `run'
/Users/anaulin/.gem/ruby/2.7.2/gems/autoprefixer-rails-9.5.1/lib/autoprefixer-rails/sprockets.rb:14:in `call'
[ SNIP ]

For details on the underlying bug, see: ai/autoprefixer-rails#203

@anaulin
Copy link
Contributor Author

anaulin commented Jun 3, 2021

Going to yolo-merge this to unblock deploys to staging, but feel free to raise any issues and I'm happy to address in a follow-up.

@anaulin anaulin merged commit 2bdb05a into development Jun 3, 2021
@anaulin anaulin deleted the fix-rails-build branch June 3, 2021 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant