Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open url on iOS #48

Merged
merged 4 commits into from Aug 18, 2022
Merged

Open url on iOS #48

merged 4 commits into from Aug 18, 2022

Conversation

hakolao
Copy link
Contributor

@hakolao hakolao commented Aug 18, 2022

Here's a PR that adds browser open on iOS opening the browser using objc crate.

I've only ran this with my own project using iPhone 8 Plus.

Tests are not covered.

Copy link
Owner

@amodm amodm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for landing the iOS support @hakolao. Long awaited! I've put in some comments about bringing consistency to code style. Subject to those, this is good to merge.

If you find the time, you can explore tests/test_android.rs to include a test for this. If not, I'll add it after the merge, but I'll need a github link to the test project you used locally. Appreciate the help on this.

src/ios.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
@hakolao
Copy link
Contributor Author

hakolao commented Aug 18, 2022

Great suggestions! It's indeed much cleaner now. I've addressed the changes requested. Here is an example project that only opens url on iOS after 2 seconds.

I use cargo-mobile to generate the xcode project and to run the builds.

@hakolao
Copy link
Contributor Author

hakolao commented Aug 18, 2022

If you find the time, you can explore tests/test_android.rs to include a test for this

Unfortunately I won't have time for this currently, but I'll be eager to see what kind of a test setup you'll make for iOS.

@amodm amodm merged commit 3ee22d3 into amodm:main Aug 18, 2022
@amodm
Copy link
Owner

amodm commented Aug 18, 2022

Congratulations on your first PR, @hakolao 🥳

Windows build VM has been a bit unreliable, so I'm ignoring the test result (your code didn't touch it anyways). This will get released after I've had the time to write tests for ios.

@hakolao
Copy link
Contributor Author

hakolao commented Aug 18, 2022

Amazing! 🥳, thanks for the review!

@amodm
Copy link
Owner

amodm commented Sep 9, 2022

FYI, this is now out in v0.8.0 release.

@hakolao
Copy link
Contributor Author

hakolao commented Sep 9, 2022

Amazing! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants