This repository has been archived by the owner on Dec 4, 2019. It is now read-only.
Add support for page#reload #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| yield page.open('http://localhost:8888/test'); | ||
| yield page.on('onNavigationRequested', function(url, type) { | ||
| if (type === 'Reload') { |
There was a problem hiding this comment.
I wish there was a better way to test this so that it doesn't rely on a functionality of another method. I don't think there is though.
There was a problem hiding this comment.
Yea, I couldn't think of any other way to verify that the page is actually reloading.
|
Merged. Will release Friday. |
|
I just released Edit: Arr. I can't figure out why the build is breaking. Working on it. |
|
I had to revert to an older eslint due to eslint/eslint#6451. I released 2.1.7 instead. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes in this pull request
The commit adds support for page#reload(). As of right now you need to evaluate the function 'location.reload()' in the context of the web page to perform a reload.
Checklist
npm testpasses successfully@amir20 to review